L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-84323 core_badges: Remove endorsement from JSON

Browse Source 
The endorsement has been removed from the JSON because, according to
the OBv2.0specification, it must not be included in either the badge
or the assertion.
Including it results in a format error, rendering the badge invalid.
This commit is contained in:
Sara Arjona
2025-01-27 10:34:26 +01:00
parent bcf06a0484
commit da2d0571ab
3 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
badges/badge_json.php
-6
View File
@@ -95,12 +95,6 @@ if ($badge->status != BADGE_STATUS_INACTIVE) {
$json['related'] = $relateds;
}
$endorsement = $badge->get_endorsement();
if (!empty($endorsement)) {
$endorsementurl = new moodle_url('/badges/endorsement_json.php', array('id' => $badge->id));
$json['endorsement'] = $endorsementurl->out(false);
}
$alignments = $badge->get_alignments();
if (!empty($alignments)) {
foreach ($alignments as $item) {
badges/classes/assertion.php
-4
View File
@@ -357,10 +357,6 @@ class core_badges_assertion {
if (!empty($relatedbadges = $this->get_related_badges($badge))) {
$json['related'] = $relatedbadges;
}
if ($endorsement = $this->get_endorsement()) {
$endorsementurl = new moodle_url('/badges/endorsement_json.php', array('id' => $this->_data->id));
$json['endorsement'] = $endorsementurl->out(false);
}
if ($alignments = $this->get_alignments()) {
$json['alignments'] = $alignments;
}
badges/tests/classes/badges_testcase.php
+2 -2
View File
@@ -166,7 +166,7 @@ abstract class badges_testcase extends \advanced_testcase {
'"criteria":{"id":"%s","narrative":"%s"},"issuer":{"name":"%s","url":"%s","email":"%s",' .
'"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"Issuer"},' .
'"tags":%s,"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"BadgeClass","version":"%s",' .
'"@language":"en","related":[{"id":"%s","version":"%s","@language":"%s"}],"endorsement":"%s",' .
'"@language":"en","related":[{"id":"%s","version":"%s","@language":"%s"}],' .
'"alignments":[{"targetName":"%s","targetUrl":"%s","targetDescription":"%s","targetFramework":"%s",' .
'"targetCode":"%s"}]},"verify":{"type":"hosted","url":"%s"},"issuedOn":"%s","evidence":"%s","tags":%s,' .
'"@context":"https:\/\/w3id.org\/openbadges\/v2","type":"Assertion","id":"%s"}';
@@ -175,7 +175,7 @@ abstract class badges_testcase extends \advanced_testcase {
'"criteria":{"id":"%s","narrative":"%s"},"issuer":{"name":"%s","url":"%s","email":"%s",' .
'"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"Issuer"},' .
'"tags":%s,"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"BadgeClass","version":"%s",' .
'"@language":"%s","related":[{"id":"%s","version":"%s","@language":"%s"}],"endorsement":"%s",' .
'"@language":"%s","related":[{"id":"%s","version":"%s","@language":"%s"}],' .
'"alignments":[{"targetName":"%s","targetUrl":"%s","targetDescription":"%s","targetFramework":"%s",' .
'"targetCode":"%s"}]}';
$this->assertion2->issuer = '{"name":"%s","url":"%s","email":"%s",' .