L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-80718 quiz: Apply overrides in mod_quiz_get_combined_review_options

Browse Source
This commit is contained in:
Dani Palou
2024-01-25 10:03:45 +01:00
parent 810554ee83
commit d638bb10cb
2 changed files with 83 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/classes/external.php
+2
View File
@@ -637,6 +637,8 @@ class mod_quiz_external extends external_api {
require_capability('mod/quiz:viewreports', $context);
}
// Update quiz with override information.
$quiz = quiz_update_effective_access($quiz, $params['userid']);
$attempts = quiz_get_user_attempts($quiz->id, $user->id, 'all', true);
$result = [];
mod/quiz/tests/external/external_test.php
Vendored
+81
View File
@@ -847,6 +847,87 @@ class external_test extends externallib_advanced_testcase {
}
}
/**
* Test get_combined_review_options when the user has an override.
*
* @covers ::get_combined_review_options
* @covers ::get_combined_review_options_parameters
* @covers ::get_combined_review_options_returns
*/
public function test_get_combined_review_options_with_overrides(): void {
global $DB;
// Create a closed quiz with review marks only when quiz is closed.
list($quiz, $context, $quizobj) = $this->create_quiz_with_questions(true, true, 'deferredfeedback', false, [
'timeclose' => time() - HOURSECS,
'marksduring' => 0,
'maxmarksduring' => 0,
'marksimmediately' => 0,
'maxmarksimmediately' => 0,
'marksopen' => 0,
'maxmarksopen' => 0,
'marksclosed' => 1,
'maxmarksclosed' => 1,
]);
// Check that the student can see the marks because the quiz is closed.
$this->setUser($this->student);
$expected = [
"someoptions" => [
["name" => "feedback", "value" => 1],
["name" => "generalfeedback", "value" => 1],
["name" => "rightanswer", "value" => 1],
["name" => "overallfeedback", "value" => 1],
["name" => "marks", "value" => 2],
],
"alloptions" => [
["name" => "feedback", "value" => 1],
["name" => "generalfeedback", "value" => 1],
["name" => "rightanswer", "value" => 1],
["name" => "overallfeedback", "value" => 1],
["name" => "marks", "value" => 2],
],
"warnings" => [],
];
$result = mod_quiz_external::get_combined_review_options($quiz->id);
$result = external_api::clean_returnvalue(mod_quiz_external::get_combined_review_options_returns(), $result);
$this->assertEquals($expected, $result);
// Add an override for the student to increase the close time.
$DB->insert_record('quiz_overrides', [
'quiz' => $quiz->id,
'userid' => $this->student->id,
'timeclose' => time() + HOURSECS,
]);
// Check that now the marks option has changed.
$expected = [
"someoptions" => [
["name" => "feedback", "value" => 1],
["name" => "generalfeedback", "value" => 1],
["name" => "rightanswer", "value" => 1],
["name" => "overallfeedback", "value" => 1],
["name" => "marks", "value" => 0],
],
"alloptions" => [
["name" => "feedback", "value" => 1],
["name" => "generalfeedback", "value" => 1],
["name" => "rightanswer", "value" => 1],
["name" => "overallfeedback", "value" => 1],
["name" => "marks", "value" => 0],
],
"warnings" => [],
];
$result = mod_quiz_external::get_combined_review_options($quiz->id);
$result = external_api::clean_returnvalue(mod_quiz_external::get_combined_review_options_returns(), $result);
$this->assertEquals($expected, $result);
}
/**
* Test start_attempt
*/