L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

file resources: MDL-14541 Object tag embedding PDF's and nested Flash objects does not work reliably

Browse Source 
Credit goes to David Boyer for reporting and suggesting the fix for PDF files,
and Jon Witts & Mauno Korpelainen for proving a way to reproduce the Flash
issue and tips to fix it.
This commit is contained in:
iarenaza
2008-11-15 12:22:32 +00:00
parent dd50f0d6da
commit d430e7feb5
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/resource/type/file/resource.class.php
+3
View File
@@ -637,12 +637,14 @@ class resource_file extends resource_base {
echo '<param name="loop" value="true" />';
echo '<param name="controller" value="true" />';
echo '<param name="scale" value="aspect" />';
echo '<param name="base" value="." />';
echo '<!--[if !IE]>-->';
echo "<object type=\"application/x-shockwave-flash\" data=\"$fullurl\">";
echo '<param name="controller" value="true" />';
echo '<param name="autoplay" value="true" />';
echo '<param name="loop" value="true" />';
echo '<param name="scale" value="aspect" />';
echo '<param name="base" value="." />';
echo '<!--<![endif]-->';
echo '<a href="' . $fullurl . '">' . $fullurl . '</a>';
echo '<!--[if !IE]>-->';
@@ -659,6 +661,7 @@ class resource_file extends resource_base {
} elseif ($resourcetype == 'pdf') {
echo '<div class="resourcepdf">';
echo '<object data="' . $fullurl . '" type="application/pdf">';
echo '<param name="src" value="' . $fullurl . '" />';
echo get_string('clicktoopen', 'resource') . '<a href="' . $fullurl . '">' . format_string($resource->name) . '</a>';
echo '</object>';
echo '</div>';