L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-22112 Wiki 2.0 upgrade code - PostgreSQL errors

Browse Source 
Firstly, double quotes are used to quote columns in PostgreSQL - let $DB
to deal with quoting of constant strings. Secondly, PostgreSQL does not
seem support table name aliases in UPDATE.
This commit is contained in:
David Mudrak
2010-05-02 17:29:21 +00:00
parent 64fc50d0fc
commit d3dbc520c4
1 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/wiki/db/upgrade.php
+15 -16
View File
@@ -110,22 +110,21 @@ function xmldb_wiki_upgrade($oldversion) {
upgrade_set_timeout();
// Setting up wiki configuration
$sql = 'UPDATE {wiki} w ' .
'SET w.intro = w.summary, ' .
'w.firstpagetitle = w.pagename, ' .
'w.defaultformat = "html"';
$sql = 'UPDATE {wiki} ' .
'SET intro = summary, ' .
'firstpagetitle = pagename, ' .
'defaultformat = ?';
$DB->execute($sql, array('html'));
$DB->execute($sql);
$sql = 'UPDATE {wiki} ' .
'SET wikimode = ? ' .
'WHERE wtype = ?';
$DB->execute($sql, array('collaborative', 'group'));
$sql = 'UPDATE {wiki} w ' .
'SET w.wikimode = "collaborative" ' .
'WHERE w.wtype = "group"';
$DB->execute($sql);
$sql = 'UPDATE {wiki} w ' .
'SET w.wikimode = "individual" ' .
'WHERE w.wtype != "group"';
$DB->execute($sql);
$sql = 'UPDATE {wiki} ' .
'SET wikimode = ? ' .
'WHERE wtype != ?';
$DB->execute($sql, array('individual', 'group'));
// Removing edit & create capability to students in old teacher wikis
$studentroles = $DB->get_records('role', array('archetype' => 'student'));
@@ -173,7 +172,7 @@ function xmldb_wiki_upgrade($oldversion) {
*/
$sql = 'INSERT into {wiki_pages} (subwikiid, title, cachedcontent, timecreated, timemodified, userid, pageviews) ' .
'SELECT s.id, p.pagename, "**reparse needed**", p.created, p.lastmodified, p.userid, p.hits ' .
'SELECT s.id, p.pagename, ?, p.created, p.lastmodified, p.userid, p.hits ' .
'FROM {wiki_pages_old} p '.
'LEFT OUTER JOIN {wiki_entries_old} e ON e.id = p.wiki ' .
'LEFT OUTER JOIN {wiki_subwikis} s ' .
@@ -187,7 +186,7 @@ function xmldb_wiki_upgrade($oldversion) {
' LIMIT 1)';
echo $OUTPUT->notification('Migrating old pages to new pages', 'notifysuccess');
$DB->execute($sql, array());
$DB->execute($sql, array('**reparse needed**'));
upgrade_mod_savepoint($result, 2010040105, 'wiki');
}