L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-59437 behat: avoid using participants page for tag tests

Browse Source 
While participants page is being refactored, there are links (fullname)
going and changing, leading to inestability in tests that were using
those links.

When possible, provide an alternative, stable path, in this case, the
tags page itself can be used to jump to the user profile, keeping the
tag tests better isolated.
This commit is contained in:
Eloy Lafuente (stronk7)
2017-07-13 11:48:35 +08:00
committed by Damyon Wiese
parent 28fcc33944
commit d131489e3d
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tag/tests/behat/edit_tag.feature
+9 -6
View File
@@ -32,9 +32,10 @@ Feature: Users can edit tags to add description or rename
And I log out
When I log in as "editor1"
And I press "Customise this page"
# TODO MDL-57120 site "Participants" link not accessible without navigation block.
# TODO MDL-57120 site "Tags" link not accessible without navigation block.
And I add the "Navigation" block if not present
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Turtle"
And I follow "User 1"
And I follow "Cat"
And I follow "Edit this tag"
@@ -56,9 +57,10 @@ Feature: Users can edit tags to add description or rename
Scenario: Manager can change tag description, related tags and rename the tag from tag view page
When I log in as "manager1"
And I press "Customise this page"
# TODO MDL-57120 site "Participants" link not accessible without navigation block.
# TODO MDL-57120 site "Tags" link not accessible without navigation block.
And I add the "Navigation" block if not present
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Turtle"
And I follow "User 1"
And I follow "Cat"
And I follow "Edit this tag"
@@ -88,9 +90,10 @@ Feature: Users can edit tags to add description or rename
Scenario: Renaming the tag from tag view page
When I log in as "manager1"
And I press "Customise this page"
# TODO MDL-57120 site "Participants" link not accessible without navigation block.
# TODO MDL-57120 site "Tags" link not accessible without navigation block.
And I add the "Navigation" block if not present
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Turtle"
And I follow "User 1"
And I follow "Cat"
And I follow "Edit this tag"
tag/tests/behat/flag_tags.feature
+8 -5
View File
@@ -25,15 +25,17 @@ Feature: Users can flag tags and manager can reset flags
And I log out
And I log in as "user2"
And I press "Customise this page"
# TODO MDL-57120 site "Participants" link not accessible without navigation block.
# TODO MDL-57120 site "Tags" link not accessible without navigation block.
And I add the "Navigation" block if not present
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Nicetag"
And I follow "User 1"
And I follow "Badtag"
And I follow "Flag as inappropriate"
And I should see "The person responsible will be notified"
And I am on homepage
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Nicetag"
And I follow "User 1"
And I follow "Sweartag"
And I follow "Flag as inappropriate"
@@ -41,9 +43,10 @@ Feature: Users can flag tags and manager can reset flags
And I log out
And I log in as "user3"
And I press "Customise this page"
# TODO MDL-57120 site "Participants" link not accessible without navigation block.
# TODO MDL-57120 site "Tags" link not accessible without navigation block.
And I add the "Navigation" block if not present
And I navigate to "Participants" node in "Site pages"
And I navigate to "Tags" node in "Site pages"
And I follow "Nicetag"
And I follow "User 1"
And I follow "Sweartag"
And I follow "Flag as inappropriate"