L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-15471 tag: minor coding style fixes

Browse Source
This commit is contained in:
Dan Poltawski
2012-09-26 12:06:46 +08:00
parent 680afde951
commit d0dff189b0
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
blocks/tags/block_tags.php
+5 -5
View File
@@ -111,10 +111,10 @@ class block_tags extends block_base {
$moretags = new moodle_url('/tag/coursetags_more.php', array('show'=>$tagtype));
if ($tagtype == 'all') {
$tags = coursetag_get_tags(0, 0, $this->config->tagtype, $this->config->numberoftags, 'name');
} else if ($tagtype=='course') {
} else if ($tagtype == 'course') {
$tags = coursetag_get_tags($this->page->course->id, 0, $this->config->tagtype, $this->config->numberoftags, 'name');
$moretags->param('courseid', $this->page->course->id);
} else if ($tagtype=='my') {
} else if ($tagtype == 'my') {
$tags = coursetag_get_tags(0, $USER->id, $this->config->tagtype, $this->config->numberoftags, 'name');
}
$tagcloud = tag_print_cloud($tags, 150, true);
@@ -142,7 +142,7 @@ class block_tags extends block_base {
has_capability('moodle/tag:create', context_course::instance($this->page->course->id))) {
$buttonadd = get_string('add', 'block_tags');
$arrowtitle = get_string('arrowtitle', 'block_tags');
$edit_tags = get_string('edittags', 'block_tags');
$edittags = get_string('edittags', 'block_tags');
$sesskey = sesskey();
$arrowright = $OUTPUT->pix_url('t/arrow_left');
$redirect = $this->page->url->out();
@@ -173,7 +173,7 @@ class block_tags extends block_base {
</div>
<div style="display: inline;">
<button type="submit">$buttonadd</button>
<a href="$CFG->wwwroot/tag/coursetags_edit.php?courseid=$COURSE->id" title="$edit_tags">$edit_tags</a>
<a href="$CFG->wwwroot/tag/coursetags_edit.php?courseid=$COURSE->id" title="$edittags">$edittags</a>
</div>
</div>
</form>
@@ -190,4 +190,4 @@ EOT;
return $this->content;
}
}
}
tag/locallib.php
-2
View File
@@ -37,8 +37,6 @@ require_once($CFG->libdir.'/filelib.php');
* @param bool $return if true the function will return the generated tag cloud instead of displaying it.
* @return string|null a HTML string or null if this function does the output
*/
//TODO question for integrator - for contrib work would it be best to add $tagset at the end of the parameter list
// not the beginning? I put it at the beginning because it sits better as alternative to $nr_of_tags there
function tag_print_cloud($tagset=null, $nr_of_tags=150, $return=false) {
global $CFG, $DB;