L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-43857: Auto clean tag bloat from word/openoffice/googledocs

Browse Source 
The cleanup rules are pulled from both testing of live docs, and the
jquery clean plugin. I tested with googledocs, libreoffice, word 2003
and word 2013.
This commit is contained in:
Damyon Wiese
2014-03-26 09:59:35 +08:00
parent b269f635f6
commit d088a835d1
6 changed files with 214 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-debug.js
Vendored
+70
View File
@@ -387,6 +387,9 @@ M.editor_atto = M.editor_atto || {
// Copy text to editable div.
atto.append(textarea.get('value'));
// Clean it.
atto.cleanHTML();
// Add the toolbar and editable zone to the page.
textarea.get('parentNode').insert(wrapper, textarea);
atto.setStyle('color', textarea.getStyle('color'));
@@ -463,6 +466,9 @@ M.editor_atto = M.editor_atto || {
node.remove(true);
});
// Remove any and all nasties from source.
atto.cleanHTML();
return atto.getHTML();
},
@@ -719,6 +725,70 @@ Y.extend(CONTROLMENU, M.core.dialogue, {
M.editor_atto = M.editor_atto || {};
M.editor_atto.controlmenu = CONTROLMENU;
/**
* Class for cleaning ugly HTML.
* Rewritten JS from jquery-clean plugin.
*
* @module editor_atto
* @chainable
*/
function cleanHTML() {
var cleaned = this.getHTML();
// What are we doing ?
// We are cleaning random HTML from all over the shop into a set of useful html suitable for content.
// We are allowing styles etc, but not e.g. font tags, class="MsoNormal" etc.
var rules = [
// Source: "http://stackoverflow.com/questions/2875027/clean-microsoft-word-pasted-text-using-javascript"
// Source: "http://stackoverflow.com/questions/1068280/javascript-regex-multiline-flag-doesnt-work"
// Remove all HTML comments.
{regex: /<!--[\s\S]*?-->/gi, replace: ""},
// Source: "http://www.1stclassmedia.co.uk/developers/clean-ms-word-formatting.php"
// Remove <?xml>, <\?xml>.
{regex: /<\\?\?xml[^>]*>/gi, replace: ""},
// Remove <o:blah>, <\o:blah>.
{regex: /<\/?\w+:[^>]*>/gi, replace: ""}, // e.g. <o:p...
// Remove MSO-blah, MSO:blah (e.g. in style attributes)
{regex: /\s*MSO[-:][^;"']*;?/gi, replace: ""},
// Remove empty spans
{regex: /<span[^>]*>(&nbsp;|\s)*<\/span>/gi, replace: ""},
// Remove class="Msoblah"
{regex: /class="Mso[^"]*"/gi, replace: ""},
// Source: "http://www.codinghorror.com/blog/2006/01/cleaning-words-nasty-html.html"
// Remove forbidden tags for content, title, meta, style, st0-9, head, font, html, body.
{regex: /<(\/?title|\/?meta|\/?style|\/?st\d|\/?head|\/?font|\/?html|\/?body|!\[)[^>]*?>/gi, replace: ""},
// Source: "http://www.tim-jarrett.com/labs_javascript_scrub_word.php"
// Replace extended chars with simple text.
{regex: new RegExp(String.fromCharCode(8220), 'gi'), replace: '"'},
{regex: new RegExp(String.fromCharCode(8216), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8217), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8211), 'gi'), replace: '-'},
{regex: new RegExp(String.fromCharCode(8212), 'gi'), replace: '--'},
{regex: new RegExp(String.fromCharCode(189), 'gi'), replace: '1/2'},
{regex: new RegExp(String.fromCharCode(188), 'gi'), replace: '1/4'},
{regex: new RegExp(String.fromCharCode(190), 'gi'), replace: '3/4'},
{regex: new RegExp(String.fromCharCode(169), 'gi'), replace: '(c)'},
{regex: new RegExp(String.fromCharCode(174), 'gi'), replace: '(r)'},
{regex: new RegExp(String.fromCharCode(8230), 'gi'), replace: '...'}
];
var i = 0, rule;
for (i = 0; i < rules.length; i++) {
rule = rules[i];
cleaned = cleaned.replace(rule.regex, rule.replace);
}
this.setHTML(cleaned);
return this;
}
Y.Node.addMethod("cleanHTML", cleanHTML);
Y.NodeList.importMethod(Y.Node.prototype, "cleanHTML");
}, '@VERSION@', {"requires": ["node", "io", "overlay", "escape", "event", "moodle-core-notification"]});
lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
Vendored
+2 -2
View File
File diff suppressed because one or more lines are too long
lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor.js
Vendored
+70
View File
@@ -387,6 +387,9 @@ M.editor_atto = M.editor_atto || {
// Copy text to editable div.
atto.append(textarea.get('value'));
// Clean it.
atto.cleanHTML();
// Add the toolbar and editable zone to the page.
textarea.get('parentNode').insert(wrapper, textarea);
atto.setStyle('color', textarea.getStyle('color'));
@@ -463,6 +466,9 @@ M.editor_atto = M.editor_atto || {
node.remove(true);
});
// Remove any and all nasties from source.
atto.cleanHTML();
return atto.getHTML();
},
@@ -719,6 +725,70 @@ Y.extend(CONTROLMENU, M.core.dialogue, {
M.editor_atto = M.editor_atto || {};
M.editor_atto.controlmenu = CONTROLMENU;
/**
* Class for cleaning ugly HTML.
* Rewritten JS from jquery-clean plugin.
*
* @module editor_atto
* @chainable
*/
function cleanHTML() {
var cleaned = this.getHTML();
// What are we doing ?
// We are cleaning random HTML from all over the shop into a set of useful html suitable for content.
// We are allowing styles etc, but not e.g. font tags, class="MsoNormal" etc.
var rules = [
// Source: "http://stackoverflow.com/questions/2875027/clean-microsoft-word-pasted-text-using-javascript"
// Source: "http://stackoverflow.com/questions/1068280/javascript-regex-multiline-flag-doesnt-work"
// Remove all HTML comments.
{regex: /<!--[\s\S]*?-->/gi, replace: ""},
// Source: "http://www.1stclassmedia.co.uk/developers/clean-ms-word-formatting.php"
// Remove <?xml>, <\?xml>.
{regex: /<\\?\?xml[^>]*>/gi, replace: ""},
// Remove <o:blah>, <\o:blah>.
{regex: /<\/?\w+:[^>]*>/gi, replace: ""}, // e.g. <o:p...
// Remove MSO-blah, MSO:blah (e.g. in style attributes)
{regex: /\s*MSO[-:][^;"']*;?/gi, replace: ""},
// Remove empty spans
{regex: /<span[^>]*>(&nbsp;|\s)*<\/span>/gi, replace: ""},
// Remove class="Msoblah"
{regex: /class="Mso[^"]*"/gi, replace: ""},
// Source: "http://www.codinghorror.com/blog/2006/01/cleaning-words-nasty-html.html"
// Remove forbidden tags for content, title, meta, style, st0-9, head, font, html, body.
{regex: /<(\/?title|\/?meta|\/?style|\/?st\d|\/?head|\/?font|\/?html|\/?body|!\[)[^>]*?>/gi, replace: ""},
// Source: "http://www.tim-jarrett.com/labs_javascript_scrub_word.php"
// Replace extended chars with simple text.
{regex: new RegExp(String.fromCharCode(8220), 'gi'), replace: '"'},
{regex: new RegExp(String.fromCharCode(8216), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8217), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8211), 'gi'), replace: '-'},
{regex: new RegExp(String.fromCharCode(8212), 'gi'), replace: '--'},
{regex: new RegExp(String.fromCharCode(189), 'gi'), replace: '1/2'},
{regex: new RegExp(String.fromCharCode(188), 'gi'), replace: '1/4'},
{regex: new RegExp(String.fromCharCode(190), 'gi'), replace: '3/4'},
{regex: new RegExp(String.fromCharCode(169), 'gi'), replace: '(c)'},
{regex: new RegExp(String.fromCharCode(174), 'gi'), replace: '(r)'},
{regex: new RegExp(String.fromCharCode(8230), 'gi'), replace: '...'}
];
var i = 0, rule;
for (i = 0; i < rules.length; i++) {
rule = rules[i];
cleaned = cleaned.replace(rule.regex, rule.replace);
}
this.setHTML(cleaned);
return this;
}
Y.Node.addMethod("cleanHTML", cleanHTML);
Y.NodeList.importMethod(Y.Node.prototype, "cleanHTML");
}, '@VERSION@', {"requires": ["node", "io", "overlay", "escape", "event", "moodle-core-notification"]});
lib/editor/atto/yui/src/editor/build.json
+2 -1
View File
@@ -4,7 +4,8 @@
"moodle-editor_atto-editor": {
"jsfiles": [
"editor.js",
"controlmenu.js"
"controlmenu.js",
"clean.js"
]
}
}
lib/editor/atto/yui/src/editor/js/clean.js
Vendored
+64
View File
@@ -0,0 +1,64 @@
/**
* Class for cleaning ugly HTML.
* Rewritten JS from jquery-clean plugin.
*
* @module editor_atto
* @chainable
*/
function cleanHTML() {
var cleaned = this.getHTML();
// What are we doing ?
// We are cleaning random HTML from all over the shop into a set of useful html suitable for content.
// We are allowing styles etc, but not e.g. font tags, class="MsoNormal" etc.
var rules = [
// Source: "http://stackoverflow.com/questions/2875027/clean-microsoft-word-pasted-text-using-javascript"
// Source: "http://stackoverflow.com/questions/1068280/javascript-regex-multiline-flag-doesnt-work"
// Remove all HTML comments.
{regex: /<!--[\s\S]*?-->/gi, replace: ""},
// Source: "http://www.1stclassmedia.co.uk/developers/clean-ms-word-formatting.php"
// Remove <?xml>, <\?xml>.
{regex: /<\\?\?xml[^>]*>/gi, replace: ""},
// Remove <o:blah>, <\o:blah>.
{regex: /<\/?\w+:[^>]*>/gi, replace: ""}, // e.g. <o:p...
// Remove MSO-blah, MSO:blah (e.g. in style attributes)
{regex: /\s*MSO[-:][^;"']*;?/gi, replace: ""},
// Remove empty spans
{regex: /<span[^>]*>(&nbsp;|\s)*<\/span>/gi, replace: ""},
// Remove class="Msoblah"
{regex: /class="Mso[^"]*"/gi, replace: ""},
// Source: "http://www.codinghorror.com/blog/2006/01/cleaning-words-nasty-html.html"
// Remove forbidden tags for content, title, meta, style, st0-9, head, font, html, body.
{regex: /<(\/?title|\/?meta|\/?style|\/?st\d|\/?head|\/?font|\/?html|\/?body|!\[)[^>]*?>/gi, replace: ""},
// Source: "http://www.tim-jarrett.com/labs_javascript_scrub_word.php"
// Replace extended chars with simple text.
{regex: new RegExp(String.fromCharCode(8220), 'gi'), replace: '"'},
{regex: new RegExp(String.fromCharCode(8216), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8217), 'gi'), replace: "'"},
{regex: new RegExp(String.fromCharCode(8211), 'gi'), replace: '-'},
{regex: new RegExp(String.fromCharCode(8212), 'gi'), replace: '--'},
{regex: new RegExp(String.fromCharCode(189), 'gi'), replace: '1/2'},
{regex: new RegExp(String.fromCharCode(188), 'gi'), replace: '1/4'},
{regex: new RegExp(String.fromCharCode(190), 'gi'), replace: '3/4'},
{regex: new RegExp(String.fromCharCode(169), 'gi'), replace: '(c)'},
{regex: new RegExp(String.fromCharCode(174), 'gi'), replace: '(r)'},
{regex: new RegExp(String.fromCharCode(8230), 'gi'), replace: '...'}
];
var i = 0, rule;
for (i = 0; i < rules.length; i++) {
rule = rules[i];
cleaned = cleaned.replace(rule.regex, rule.replace);
}
this.setHTML(cleaned);
return this;
}
Y.Node.addMethod("cleanHTML", cleanHTML);
Y.NodeList.importMethod(Y.Node.prototype, "cleanHTML");
lib/editor/atto/yui/src/editor/js/editor.js
Vendored
+6
View File
@@ -385,6 +385,9 @@ M.editor_atto = M.editor_atto || {
// Copy text to editable div.
atto.append(textarea.get('value'));
// Clean it.
atto.cleanHTML();
// Add the toolbar and editable zone to the page.
textarea.get('parentNode').insert(wrapper, textarea);
atto.setStyle('color', textarea.getStyle('color'));
@@ -461,6 +464,9 @@ M.editor_atto = M.editor_atto || {
node.remove(true);
});
// Remove any and all nasties from source.
atto.cleanHTML();
return atto.getHTML();
},