MDL-38824 Activity completion: Automatic completion quotes not escaped

2013-04-08 14:53:38 +01:00
parent bd11908373
commit cfd41befd5
1 changed files with 4 additions and 3 deletions
@@ -1679,9 +1679,10 @@ function print_section($course, $section, $mods, $modnamesused, $absolute=false,
                        echo html_writer::end_tag('div');
                        echo html_writer::end_tag('form');
                    } else {
-                        // In auto mode, or when editing, the icon is just an image
-                        echo "<span class='autocompletion'>";
-                        echo "<img src='$imgsrc' alt='$imgalt' title='$imgalt' /></span>";
+                        // In auto mode, or when editing, the icon is just an image.
+                        echo html_writer::tag('span', html_writer::empty_tag('img', array(
+                                'src' => $imgsrc, 'alt' => $imgalt, 'title' => $imgalt)),
+                                array('class' => 'autocompletion'));
                    }
                }
            }