L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-83691 core_sms: Avoid saving unnecessary data in the database

Browse Source
This commit is contained in:
meirzamoodle
2024-12-13 10:16:33 +07:00
parent 4bd3217ce8
commit cc77d48e7c
3 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/db/upgrade.php
+19
View File
@@ -1444,6 +1444,25 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2024100100.02);
}
if ($oldversion < 2024100701.01) {
$smsgateways = $DB->get_records('sms_gateways');
foreach ($smsgateways as $gateway) {
$newconfig = json_decode($gateway->config);
// Continue only if either the `returnurl` OR the `saveandreturn` property exists.
if (property_exists($newconfig, "returnurl") || property_exists($newconfig, "saveandreturn")) {
// Remove unnecessary data in the config.
unset($newconfig->returnurl, $newconfig->saveandreturn);
// Update the record with the new config.
$gateway->config = json_encode($newconfig);
$DB->update_record('sms_gateways', $gateway);
}
}
// Main savepoint reached.
upgrade_main_savepoint(true, 2024100701.01);
}
// Automatically generated Moodle v4.5.0 release upgrade line.
// Put any upgrade step following this.
sms/configure.php
+2 -1
View File
@@ -96,7 +96,8 @@ if ($data = $mform->get_data()) {
$manager = \core\di::get(\core_sms\manager::class);
$smsgateway = $data->smsgateway;
$gatewayname = $data->name;
unset($data->smsgateway, $data->name, $data->id);
// The $data will go into the database config column. If any data is not needed, unset it here.
unset($data->smsgateway, $data->name, $data->id, $data->saveandreturn, $data->returnurl);
if (!empty($id)) {
$gatewayinstance = $manager->get_gateway_instances(['id' => $id]);
$gatewayinstance = reset($gatewayinstance);
version.php
+1 -1
View File
@@ -29,7 +29,7 @@
defined('MOODLE_INTERNAL') || die();
$version = 2024100701.00; // 20241007 = branching date YYYYMMDD - do not modify!
$version = 2024100701.01; // 20241007 = branching date YYYYMMDD - do not modify!
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
$release = '4.5.1 (Build: 20241209)'; // Human-friendly version name