L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-68343 gradereport_singleview: fix empty links

Browse Source
This commit is contained in:
Shamim Rezaie
2020-04-22 04:31:06 +10:00
parent 5d2be187a2
commit cc36c39b46
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/lib.php
+3 -2
View File
@@ -1791,8 +1791,9 @@ class grade_structure {
return '';
}
return $OUTPUT->action_icon($url, new pix_icon('t/preview',
get_string('gradeanalysis', 'core_grades')));
$title = get_string('gradeanalysis', 'core_grades');
return $OUTPUT->action_icon($url, new pix_icon('t/preview', ''), null,
['title' => $title, 'aria-label' => $title]);
}
/**
grade/report/singleview/classes/local/screen/grade.php
+2 -1
View File
@@ -210,7 +210,8 @@ class grade extends tablelike implements selectable_items, filterable_items {
$grade->label = $fullname;
$line = array(
$OUTPUT->action_icon($this->format_link('user', $item->id), new pix_icon('t/editstring', $iconstring)),
$OUTPUT->action_icon($this->format_link('user', $item->id), new pix_icon('t/editstring', ''), null,
['title' => $iconstring, 'aria-label' => $iconstring]),
$OUTPUT->user_picture($item, array('visibletoscreenreaders' => false)) .
html_writer::link($url, $fullname),
$this->item_range()
grade/report/singleview/classes/local/screen/user.php
+2 -1
View File
@@ -190,7 +190,8 @@ class user extends tablelike implements selectable_items {
$grade->label = $item->get_name();
$line = array(
$OUTPUT->action_icon($this->format_link('grade', $item->id), new pix_icon('t/editstring', $iconstring)),
$OUTPUT->action_icon($this->format_link('grade', $item->id), new pix_icon('t/editstring', ''), null,
['title' => $iconstring, 'aria-label' => $iconstring]),
$this->format_icon($item) . $lockicon . $itemlabel,
$this->category($item),
new range($item)