L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-39306 fix course search regression

Browse Source 
Oracle handling of NULLs is totally wrong and crazy!
This commit is contained in:
Petr Škoda
2013-04-23 12:36:50 +02:00
parent a4fea69fde
commit cc1e433286
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/datalib.php
+2 -3
View File
@@ -720,10 +720,9 @@ function get_courses_search($searchterms, $sort, $page, $recordsperpage, &$total
// Thanks Oracle for your non-ansi concat and type limits in coalesce. MDL-29912
if ($DB->get_dbfamily() == 'oracle') {
$concat = $DB->sql_concat('c.summary', "' '", 'c.fullname', "' '", 'c.idnumber', "' '", 'c.shortname');
$concat = "(c.summary|| ' ' || c.fullname || ' ' || c.idnumber || ' ' || c.shortname)";
} else {
$concat = $DB->sql_concat("COALESCE(c.summary, :empty)", "' '", 'c.fullname', "' '", 'c.idnumber', "' '", 'c.shortname');
$params['empty'] = '';
$concat = $DB->sql_concat("COALESCE(c.summary, '')", "' '", 'c.fullname', "' '", 'c.idnumber', "' '", 'c.shortname');
}
foreach ($searchterms as $searchterm) {