L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42880 quiz settings: remove unnecessary disabledif rules.

Browse Source 
These rules were causing problems in the case where the form was
sumitted with validation errors. In that case, the During the attempt ->
The attempt checkbox was becoming unset, and hence the other During the
attmept checkboxes became disabled, and the values were not saved.

Thanks to Sam Marshall for suggesting this fix.
This commit is contained in:
Tim Hunt
2013-11-15 19:20:20 +00:00
parent 9f887be6a6
commit cade07b451
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/mod_form.php
+6 -4
View File
@@ -424,10 +424,12 @@ class mod_quiz_mod_form extends moodleform_mod {
}
}
$mform->disabledIf('correctness' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('specificfeedback' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('generalfeedback' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('rightanswer' . $whenname, 'attempt' . $whenname);
if ($whenname != 'during') {
$mform->disabledIf('correctness' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('specificfeedback' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('generalfeedback' . $whenname, 'attempt' . $whenname);
$mform->disabledIf('rightanswer' . $whenname, 'attempt' . $whenname);
}
}
protected function preprocessing_review_settings(&$toform, $whenname, $when) {