L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-72329 tool_dataprivacy: Fix type comparisons in unit tests

Browse Source
This commit is contained in:
David Matamoros
2021-09-24 08:45:09 +02:00
parent 306b070ac1
commit c6cf30d47a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/dataprivacy/classes/external.php
+1 -1
View File
@@ -107,7 +107,7 @@ class external extends external_api {
$request = reset($requests);
$datasubject = $request->get('userid');
if ($datasubject !== $USER->id) {
if ($datasubject !== (int) $USER->id) {
// The user is not the subject. Check that they can cancel this request.
if (!api::can_create_data_request_for_user($datasubject)) {
$forusercontext = \context_user::instance($datasubject);
admin/tool/dataprivacy/tests/expired_contexts_test.php
+2 -2
View File
@@ -713,7 +713,7 @@ class tool_dataprivacy_expired_contexts_testcase extends advanced_testcase {
$unexpiredroles = $expiredrecord->get('unexpiredroles');
$this->assertCount(1, $unexpiredroles);
$this->assertContains($role->id, $unexpiredroles);
$this->assertContainsEquals($role->id, $unexpiredroles);
}
/**
@@ -820,7 +820,7 @@ class tool_dataprivacy_expired_contexts_testcase extends advanced_testcase {
// The teacher is not expired.
$unexpiredroles = $expiredrecord->get('unexpiredroles');
$this->assertCount(1, $unexpiredroles);
$this->assertContains($role->id, $unexpiredroles);
$this->assertContainsEquals($role->id, $unexpiredroles);
$this->assertTrue((bool) $expiredrecord->get('defaultexpired'));
}