MDL-81058 admin: fix sesskey checks for admin preset actions.

2024-04-12 11:30:23 +00:00
parent c2a043f50d
commit c5f48698da
5 changed files with 3 additions and 9 deletions
@@ -64,7 +64,7 @@ class delete extends base {
     * Delete the DB preset
     */
    public function execute(): void {
-        confirm_sesskey();
+        require_sesskey();

        $this->manager->delete_preset($this->id);

@@ -52,8 +52,6 @@ class export extends base {
     * Stores a preset into the DB.
     */
    public function execute(): void {
-        confirm_sesskey();
-
        $url = new \moodle_url('/admin/tool/admin_presets/index.php', ['action' => 'export', 'mode' => 'execute']);
        $this->moodleform = new export_form($url);

@@ -87,7 +85,7 @@ class export extends base {
     * @throws xml_writer_exception
     */
    public function download_xml(): void {
-        confirm_sesskey();
+        require_sesskey();

        list($xmlstr, $filename) = $this->manager->download_preset($this->id);

@@ -40,8 +40,6 @@ class import extends base {
     * Imports the xmlfile into DB
     */
    public function execute(): void {
-        confirm_sesskey();
-
        $url = new \moodle_url('/admin/tool/admin_presets/index.php', ['action' => 'import', 'mode' => 'execute']);
        $this->moodleform = new import_form($url);

@@ -38,8 +38,6 @@ class load extends base {
    public function execute(): void {
        global $OUTPUT;

-        confirm_sesskey();
-
        $url = new \moodle_url('/admin/tool/admin_presets/index.php', ['action' => 'load', 'mode' => 'execute']);
        $this->moodleform = new load_form($url);

@@ -73,7 +73,7 @@ class rollback extends base {
    public function execute(): void {
        global $OUTPUT;

-        confirm_sesskey();
+        require_sesskey();

        list($presetapp, $rollback, $failures) = $this->manager->revert_preset($this->id);