Merge branch 'MDL-81321' of https://github.com/paulholden/moodle

.upgradenotes/MDL-81321-2024052421223463.yml

@@ -0,0 +1,7 @@
+issueNumber: MDL-81321
+notes:
+  mod_data:
+    - message: >-
+        The `mod_data_renderer::render_fields_footer` method has been deprecated
+        as it's no longer used
+      type: deprecated

mod/data/field.php

@@ -470,9 +470,6 @@ if (($mode == 'new') && (!empty($newtype))) { // Adding a new field.
     echo '</div>';
     echo '</form>';
 
-    // Add a sticky footer.
-    echo $renderer->render_fields_footer($manager);
-
     echo '</div>';
 }
 

mod/data/renderer.php

@@ -167,8 +167,13 @@ class mod_data_renderer extends plugin_renderer_base {
      *
      * @param manager $manager the instance manager
      * @return string The HTML output
+     *
+     * @deprecated since Moodle 4.5 - please do not use this function anymore
      */
+    #[\core\attribute\deprecated(null, reason: 'It is no longer used', since: '4.5')]
     public function render_fields_footer(manager $manager): string {
+        \core\deprecation::emit_deprecation_if_present([self::class, __FUNCTION__]);
+
         $cm = $manager->get_coursemodule();
         $pageurl = new moodle_url('/mod/data/templates.php', ['id' => $cm->id]);
         return $this->render_from_template('mod_data/fields_footer', [