MDL-43262 JavaScript: Correct visible attribute override

This should be done using an attribute modification, rather than at the
constructor level.

lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-debug.js

@@ -70,7 +70,6 @@ DIALOGUE = function(c) {
     }
 
     config.srcNode =    '#'+id;
-    config.visible =    config.visible || false;
     config.center =     config.centered && true;
     config.centered =   false;
     config.COUNT = COUNT;
@@ -496,6 +495,19 @@ Y.Base.modifyAttrs(DIALOGUE, {
             }
             return value;
         }
+    },
+
+    /**
+     * Boolean indicating whether or not the Widget is visible.
+     *
+     * We override this from the default Widget attribute value.
+     *
+     * @attribute visible
+     * @default false
+     * @type Boolean
+     */
+    visible: {
+        value: false
     }
 });
 

lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue.js

@@ -70,7 +70,6 @@ DIALOGUE = function(c) {
     }
 
     config.srcNode =    '#'+id;
-    config.visible =    config.visible || false;
     config.center =     config.centered && true;
     config.centered =   false;
     config.COUNT = COUNT;
@@ -494,6 +493,19 @@ Y.Base.modifyAttrs(DIALOGUE, {
             }
             return value;
         }
+    },
+
+    /**
+     * Boolean indicating whether or not the Widget is visible.
+     *
+     * We override this from the default Widget attribute value.
+     *
+     * @attribute visible
+     * @default false
+     * @type Boolean
+     */
+    visible: {
+        value: false
     }
 });
 

lib/yui/src/notification/js/dialogue.js

@@ -39,7 +39,6 @@ DIALOGUE = function(c) {
     }
 
     config.srcNode =    '#'+id;
-    config.visible =    config.visible || false;
     config.center =     config.centered && true;
     config.centered =   false;
     config.COUNT = COUNT;
@@ -465,6 +464,19 @@ Y.Base.modifyAttrs(DIALOGUE, {
             }
             return value;
         }
+    },
+
+    /**
+     * Boolean indicating whether or not the Widget is visible.
+     *
+     * We override this from the default Widget attribute value.
+     *
+     * @attribute visible
+     * @default false
+     * @type Boolean
+     */
+    visible: {
+        value: false
     }
 });