MDL-84135 completion: correct entity table name to match schema.
This commit is contained in:
@@ -16,7 +16,7 @@ notes:
|
||||
|
||||
- `enrolment:method` (plus enrolment formatter `enrolment_name` method)
|
||||
|
||||
- 'enrolment:role`
|
||||
- `enrolment:role`
|
||||
|
||||
- `file:context`
|
||||
|
||||
|
||||
@@ -0,0 +1,7 @@
|
||||
issueNumber: MDL-84135
|
||||
notes:
|
||||
core_reportbuilder:
|
||||
- message: >-
|
||||
Use of the `course_completion` table is deprecated in the `completion`
|
||||
entity, please use `course_completions` instead
|
||||
type: deprecated
|
||||
@@ -132,7 +132,7 @@ class participants extends datasource {
|
||||
'course' => $course,
|
||||
'user' => $user,
|
||||
]);
|
||||
$completion = $completionentity->get_table_alias('course_completion');
|
||||
$completion = $completionentity->get_table_alias('course_completions');
|
||||
$this->add_entity($completionentity
|
||||
->add_joins($userentity->get_joins())
|
||||
->add_join("
|
||||
|
||||
@@ -48,14 +48,25 @@ class completion extends base {
|
||||
*/
|
||||
protected function get_default_tables(): array {
|
||||
return [
|
||||
'course_completion',
|
||||
'course',
|
||||
'course_completions',
|
||||
'grade_grades' ,
|
||||
'grade_items',
|
||||
'user',
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* Database tables that this entity no longer uses
|
||||
*
|
||||
* @return string[]
|
||||
*/
|
||||
protected function get_deprecated_tables(): array {
|
||||
return [
|
||||
'course_completions' => 'course_completion',
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* The default title for this entity in the list of columns/conditions/filters in the report builder
|
||||
*
|
||||
@@ -92,8 +103,8 @@ class completion extends base {
|
||||
*/
|
||||
protected function get_all_columns(): array {
|
||||
[
|
||||
'course_completion' => $coursecompletion,
|
||||
'course' => $course,
|
||||
'course_completions' => $coursecompletion,
|
||||
'grade_grades' => $grade,
|
||||
'grade_items' => $gradeitem,
|
||||
'user' => $user,
|
||||
@@ -295,7 +306,7 @@ class completion extends base {
|
||||
* @return filter[]
|
||||
*/
|
||||
protected function get_all_filters(): array {
|
||||
$coursecompletion = $this->get_table_alias('course_completion');
|
||||
$coursecompletion = $this->get_table_alias('course_completions');
|
||||
|
||||
// Completed status filter.
|
||||
$filters[] = (new filter(
|
||||
|
||||
Reference in New Issue
Block a user