L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29733 grade: Query for Identifying Grade Grades to Precreate is SLOW

Browse Source
This commit is contained in:
Jonathan Champ
2012-10-30 09:02:06 +08:00
committed by Andrew Davis
parent 98197952cc
commit c2539fc41d
1 changed files with 20 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/grade/grade_item.php
+20 -10
View File
@@ -1727,16 +1727,26 @@ class grade_item extends grade_object {
return true; // no need to recalculate locked items
}
// precreate grades - we need them to exist
$params = array($this->courseid, $this->id, $this->id);
$sql = "SELECT DISTINCT go.userid
FROM {grade_grades} go
JOIN {grade_items} gi
ON (gi.id = go.itemid AND gi.courseid = ?)
LEFT OUTER JOIN {grade_grades} g
ON (g.userid = go.userid AND g.itemid = ?)
WHERE gi.id <> ? AND g.id IS NULL";
if ($missing = $DB->get_records_sql($sql, $params)) {
if ($userid) {
$missing = array();
if (!$DB->record_exists('grade_grades', array('itemid'=>$this->id, 'userid'=>$userid))) {
$m = new stdClass();
$m->userid = $userid;
$missing[] = $m;
}
} else {
// precreate grades - we need them to exist
$params = array($this->courseid, $this->id);
$sql = "SELECT go.userid
FROM {grade_grades} go
JOIN {grade_items} gi
ON (gi.id = go.itemid AND gi.courseid = ?)
GROUP BY go.userid
HAVING SUM(go.itemid = ?) = 0";
$missing = $DB->get_records_sql($sql, $params);
}
if ($missing) {
foreach ($missing as $m) {
$grade = new grade_grade(array('itemid'=>$this->id, 'userid'=>$m->userid), false);
$grade->grade_item =& $this;