L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-79839 tool_task: clean task classname parameter prior to use.

Browse Source
This commit is contained in:
Paul Holden
2023-12-07 10:53:53 +08:00
committed by Jun Pataleta
parent 4329ce029a
commit c0a3fd11a0
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/task/adhoctasks.php
+1 -1
View File
@@ -35,7 +35,7 @@ $renderer = $PAGE->get_renderer('tool_task');
if ($classname) {
$pageurl = new moodle_url('/admin/tool/task/adhoctasks.php');
$PAGE->navbar->add(get_string('adhoctasks', 'tool_task'), $pageurl);
$PAGE->navbar->add($classname, $PAGE->url);
$PAGE->navbar->add(s($classname), $PAGE->url);
$tasks = core\task\manager::get_adhoc_tasks($classname, $failedonly);
admin/tool/task/renderer.php
+1 -1
View File
@@ -166,7 +166,7 @@ class tool_task_renderer extends plugin_renderer_base {
// Main tasks table.
$table = $this->generate_adhoc_tasks_simple_table($tasks, $canruntasks);
$table->caption = "$classname "
$table->caption = s($classname) . " "
. get_string($failedonly ? 'adhoctasksfailed' : 'adhoctasks', 'tool_task');
$table->head[3] .= " $failedorall"; // Spice up faildelay heading.
admin/tool/task/run_adhoctasks.php
+1 -1
View File
@@ -60,7 +60,7 @@ if ($taskid) {
if (!$classname) {
throw new \moodle_exception('noclassname', 'tool_task');
}
$heading = "Run $classname " . ($failedonly ? "failed" : "all")." tasks";
$heading = "Run " . s($classname) . " " . ($failedonly ? "failed" : "all")." tasks";
$now = time();
$tasks = array_filter(
core\task\manager::get_adhoc_tasks($classname, $failedonly, true),