L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIxed a recently-introduced bug preventing assignment grading bug 1390

Browse Source
This commit is contained in:
moodler
2004-05-15 15:21:29 +00:00
parent f24a6c878e
commit c032f72069
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assignment/submissions.php
+3 -6
View File
@@ -6,8 +6,9 @@
require_variable($id); // Assignment
optional_variable($sort, "timemodified");
optional_variable($dir, "DESC");
optional_variable($timewas);
optional_variable($timenow, 0);
$timewas = $timenow;
$timenow = time();
if (! $assignment = get_record("assignment", "id", $id)) {
@@ -113,13 +114,9 @@
// Make sure that we aren't overwriting any recent feedback from other teachers. (see bug #324)
if ($timewas < $submission->timemarked && (!empty($submission->grade)) && (!empty($submission->comment))) {
$u = $users[$submission->userid];
$uname = $u->firstname . " " . $u->lastname;
notify(get_string("failedupdatefeedback", "assignment", $uname)
notify(get_string("failedupdatefeedback", "assignment", fullname($users[$submission->userid]))
. "<br>" . get_string("grade") . ": $newsubmission->grade"
. "<br>" . get_string("feedback", "assignment") . ": $newsubmission->comment\n");
unset($u);
unset($uname);
} else { //print out old feedback and grade
if (empty($submission->timemodified)) { // eg for offline assignments
$newsubmission->timemodified = $timenow;