L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-53452 tool_lp: Rename some persistent methods for consistency

Browse Source
This commit is contained in:
Damyon Wiese
2016-04-18 10:59:00 +08:00
committed by Frederic Massart
parent 8c46097536
commit c01141d1a3
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/lp/classes/api.php
+2 -2
View File
@@ -4867,7 +4867,7 @@ class api {
static::require_enabled();
// First we do a permissions check.
if (!course_competency_settings::can_view($courseid)) {
if (!course_competency_settings::can_read($courseid)) {
$context = context_course::instance($courseid);
throw new required_capability_exception($context, 'tool/lp:coursecompetencyview', 'nopermissions', '');
}
@@ -4893,7 +4893,7 @@ class api {
$pushratingstouserplans = isset($settings->pushratingstouserplans) ? $settings->pushratingstouserplans : false;
// First we do a permissions check.
if (!course_competency_settings::can_update_course($courseid)) {
if (!course_competency_settings::can_manage_course($courseid)) {
$context = context_course::instance($courseid);
throw new required_capability_exception($context, 'tool/lp:coursecompetencyconfigure', 'nopermissions', '');
}
admin/tool/lp/classes/course_competency_settings.php
+5 -6
View File
@@ -51,6 +51,7 @@ class course_competency_settings extends persistent {
),
'pushratingstouserplans' => array(
'type' => PARAM_BOOL,
'default' => get_config('tool_lp', 'pushcourseratingstouserplans')
),
);
}
@@ -71,8 +72,6 @@ class course_competency_settings extends persistent {
$settings = new static(null, (object) $params);
if ($record = $DB->get_record(self::TABLE, $params)) {
$settings->from_record($record);
} else {
$settings->set_pushratingstouserplans(get_config('tool_lp', 'pushcourseratingstouserplans'));
}
return $settings;
@@ -84,7 +83,7 @@ class course_competency_settings extends persistent {
* @param int $data The course ID.
* @return bool
*/
public static function can_view($courseid) {
public static function can_read($courseid) {
$context = context_course::instance($courseid);
$capabilities = array('tool/lp:coursecompetencyview');
@@ -98,7 +97,7 @@ class course_competency_settings extends persistent {
* @param int $data The course ID.
* @return bool
*/
public static function can_update_course($courseid) {
public static function can_manage_course($courseid) {
$context = context_course::instance($courseid);
$capabilities = array('tool/lp:coursecompetencyconfigure');
@@ -111,8 +110,8 @@ class course_competency_settings extends persistent {
*
* @return bool
*/
public function can_update() {
return static::can_update_course($this->get_courseid());
public function can_manage() {
return static::can_manage_course($this->get_courseid());
}
/**