MDL-76849 qtype_gapselect: Include question number in answer fields

This commit is contained in:
Jun Pataleta
2023-03-09 08:58:52 +08:00
parent b71d30097e
commit bad9e0a1bc
+8 -9
View File
@@ -44,10 +44,10 @@ class qtype_gapselect_renderer extends qtype_elements_embedded_in_question_text_
$value = $qa->get_last_qt_var($question->field($place));
$attributes = array(
'id' => $this->box_id($qa, 'p' . $place),
'class' => 'custom-select place' . $place,
);
$attributes = [
'id' => $this->box_id($qa, 'p' . $place),
'class' => 'custom-select place' . $place,
];
$groupclass = 'group' . $group;
if ($options->readonly) {
@@ -55,7 +55,7 @@ class qtype_gapselect_renderer extends qtype_elements_embedded_in_question_text_
}
$orderedchoices = $question->get_ordered_choices($group);
$selectoptions = array();
$selectoptions = [];
foreach ($orderedchoices as $orderedchoicevalue => $orderedchoice) {
$selectoptions[$orderedchoicevalue] = format_string($orderedchoice->text);
}
@@ -71,13 +71,12 @@ class qtype_gapselect_renderer extends qtype_elements_embedded_in_question_text_
}
}
$label = $options->add_question_identifier_to_label(get_string('blanknumber', 'qtype_gapselect', $place));
// Use non-breaking space instead of 'Choose...'.
$selecthtml = html_writer::label(get_string('blanknumber', 'qtype_gapselect', $place),
$attributes['id'], false,
array('class' => 'sr-only'));
$selecthtml = html_writer::label($label, $attributes['id'], false, ['class' => 'sr-only']);
$selecthtml .= html_writer::select($selectoptions, $qa->get_qt_field_name($fieldname),
$value, ' ', $attributes) . ' ' . $feedbackimage;
return html_writer::tag('span', $selecthtml, array('class' => 'control '.$groupclass));
return html_writer::tag('span', $selecthtml, ['class' => 'control '.$groupclass]);
}
}