L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-15877: Lesson query breaks dml rule about reusing named params

Browse Source
This commit is contained in:
sam_marshall
2008-07-29 16:42:12 +00:00
parent 6c7696fe6a
commit b920f6e84a
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/lib.php
+4 -3
View File
@@ -341,12 +341,13 @@ function lesson_cron () {
function lesson_get_user_grades($lesson, $userid=0) {
global $CFG, $DB;
$params = array("lessonid" => $lesson->id);
$params = array("lessonid" => $lesson->id,"lessonid2" => $lesson->id);
if (isset($userid)) {
$params["userid"] = $userid;
$params["userid2"] = $userid;
$user = "AND u.id = :userid";
$fuser = "AND uu.id = :userid";
$fuser = "AND uu.id = :userid2";
}
else {
$user="";
@@ -372,7 +373,7 @@ function lesson_get_user_grades($lesson, $userid=0) {
// use only first attempts (with lowest id in lesson_grades table)
$firstonly = "SELECT uu.id AS userid, MIN(gg.id) AS firstcompleted
FROM {user} uu, {lesson_grades} gg
WHERE uu.id = gg.userid AND gg.lessonid = :lessonid
WHERE uu.id = gg.userid AND gg.lessonid = :lessonid2
$fuser
GROUP BY uu.id";