L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-69319 mod_lti: remove unused vars from externallib_test

Browse Source
This commit is contained in:
Jake Dallimore
2020-07-22 09:45:45 +08:00
parent 654c27eece
commit b77d0239b9
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lti/tests/externallib_test.php
+11 -14
View File
@@ -92,7 +92,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
* Test view_lti
*/
public function test_get_tool_launch_data() {
global $USER, $SITE;
global $USER;
$td = $this->setup_test_data();
$lti = $td['lti'];
@@ -127,8 +127,6 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
* Test get ltis by courses
*/
public function test_mod_lti_get_ltis_by_courses() {
global $DB;
$td = $this->setup_test_data();
$course = $td['course'];
$lti = $td['lti'];
@@ -259,8 +257,6 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
* Test view_lti
*/
public function test_view_lti() {
global $DB;
$td = $this->setup_test_data();
$lti = $td['lti'];
$context = $td['context'];
@@ -292,7 +288,8 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
$sink = $this->redirectEvents();
$result = mod_lti_external::view_lti($lti->id);
$result = external_api::clean_returnvalue(mod_lti_external::view_lti_returns(), $result);
// The value of the result isn't needed but validation is.
external_api::clean_returnvalue(mod_lti_external::view_lti_returns(), $result);
$events = $sink->get_events();
$this->assertCount(1, $events);
@@ -343,8 +340,8 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
public function test_mod_lti_create_tool_proxy_duplicateurl() {
$this->setAdminUser();
$this->expectException('moodle_exception');
$proxy = mod_lti_external::create_tool_proxy('Test proxy 1', $this->getExternalTestFileUrl('/test.html'), array(), array());
$proxy = mod_lti_external::create_tool_proxy('Test proxy 2', $this->getExternalTestFileUrl('/test.html'), array(), array());
mod_lti_external::create_tool_proxy('Test proxy 1', $this->getExternalTestFileUrl('/test.html'), array(), array());
mod_lti_external::create_tool_proxy('Test proxy 2', $this->getExternalTestFileUrl('/test.html'), array(), array());
}
/*
@@ -355,7 +352,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
$teacher = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
$this->setUser($teacher);
$this->expectException('required_capability_exception');
$proxy = mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), array(), array());
mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), array(), array());
}
/*
@@ -409,7 +406,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
$type->description = "Example description";
$type->toolproxyid = $proxy->id;
$type->baseurl = $this->getExternalTestFileUrl('/test.html');
$typeid = lti_add_type($type, $data);
lti_add_type($type, $data);
$types = mod_lti_external::get_tool_types($proxy->id);
$types = external_api::clean_returnvalue(mod_lti_external::get_tool_types_returns(), $types);
@@ -445,7 +442,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
*/
public function test_mod_lti_create_tool_type_nonexistant_file() {
$this->expectException('moodle_exception');
$type = mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/doesntexist.xml'), '', '');
mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/doesntexist.xml'), '', '');
}
/*
@@ -453,7 +450,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
*/
public function test_mod_lti_create_tool_type_bad_file() {
$this->expectException('moodle_exception');
$type = mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/rsstest.xml'), '', '');
mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/rsstest.xml'), '', '');
}
/*
@@ -464,7 +461,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
$teacher = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
$this->setUser($teacher);
$this->expectException('required_capability_exception');
$type = mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/ims_cartridge_basic_lti_link.xml'), '', '');
mod_lti_external::create_tool_type($this->getExternalTestFileUrl('/ims_cartridge_basic_lti_link.xml'), '', '');
}
/*
@@ -509,7 +506,7 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
$course = $this->getDataGenerator()->create_course();
$teacher = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
$this->setUser($teacher);
$type = mod_lti_external::delete_tool_type($type['id']);
mod_lti_external::delete_tool_type($type['id']);
}
/*