L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-60646 user_portfolio: Fix action icons in Show / hide column

Browse Source 
* Refactor the code to make it look cleaner and easier to read.
* Fixed incorrect alt-text for the configure icon.
* Fixed missing alt-text for show/hide icon.
This commit is contained in:
Jun Pataleta
2018-01-18 15:27:03 +08:00
parent 68673fb78d
commit b65a529086
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
user/portfolio.php
+17 -7
View File
@@ -113,14 +113,24 @@ if ($display) {
$table->data = array();
foreach ($instances as $i) {
// Contents of the actions (Show / hide) column.
$actions = '';
// Configure icon.
if ($i->has_user_config()) {
$configurl = new moodle_url($baseurl);
$configurl->param('config', $i->get('id'));
$actions .= html_writer::link($configurl, $OUTPUT->pix_icon('t/edit', get_string('configure', 'portfolio')));
}
// Hide/show icon.
$visible = $i->get_user_config('visible', $USER->id);
$table->data[] = array($i->get('name'), $i->get('plugin'),
($i->has_user_config()
? '<a href="' . $baseurl . '?config=' . $i->get('id') . '">' .
$OUTPUT->pix_icon('t/edit', get_string('configure')) . '</a>' : '') .
' <a href="' . $baseurl . '?hide=' . $i->get('id') . '">' .
$OUTPUT->pix_icon('t/' . (($visible) ? 'hide' : 'show')), get_string($visible ? 'hide' : 'show') . '</a><br />'
);
$visibilityaction = $visible ? 'hide' : 'show';
$showhideurl = new moodle_url($baseurl);
$showhideurl->param('hide', $i->get('id'));
$actions .= html_writer::link($showhideurl, $OUTPUT->pix_icon('t/' . $visibilityaction, get_string($visibilityaction)));
$table->data[] = array($i->get('name'), $i->get('plugin'), $actions);
}
echo html_writer::table($table);