L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

moodle--eduforge--1.3.3--patch-159 get_courses checks to see if sort is not empty before putting it in the query + removal of redundant (and costly) SQL SELECT

Browse Source
This commit is contained in:
martinlanghoff
2004-11-19 02:13:44 +00:00
parent 96522de058
commit b55be229e9
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/datalib.php
+1 -3
View File
@@ -1787,8 +1787,6 @@ function get_courses($categoryid="all", $sort="c.sortorder ASC", $fields="c.*")
$selectsql = "{$CFG->prefix}course c $teachertable";
}
$courses = get_records_sql("SELECT $fields FROM $selectsql ORDER BY $sort");
return get_records_sql("SELECT ".((!empty($teachertable)) ? " DISTINCT " : "")." $fields FROM $selectsql ".((!empty($sort)) ? "ORDER BY $sort" : ""));
}
@@ -1964,7 +1962,7 @@ function get_courses_search($searchterms, $sort="fullname ASC", $page=0, $record
$totalcount = count_records_sql("SELECT COUNT(*) FROM $selectsql");
$courses = get_records_sql("SELECT * FROM $selectsql ORDER BY $sort $limit");
$courses = get_records_sql("SELECT * FROM $selectsql ".((!empty($sort)) ? "ORDER BY $sort" : "")." $limit");
if ($courses) { /// Remove unavailable courses from the list
foreach ($courses as $key => $course) {