L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Fixed] Fails gracefully when no course modules are found.

Browse Source 
[Fixed] Does not remove other modules from the activity link options due to same ids.
This commit is contained in:
michaelpenne
2006-01-13 21:57:42 +00:00
parent dfd02fa5d2
commit b4f4f09ca8
1 changed files with 34 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/mod.html
+34 -31
View File
@@ -544,40 +544,43 @@ if ($form->mode == "add") {
<td>
<?php
// get the modules
$mods = get_course_mods($form->course);
$modinstances = array();
foreach ($mods as $mod) {
if ($mod->instance == $form->instance) { // don't add this lesson
continue;
}
// get the module name and then store it in a new array
if ($module = get_coursemodule_from_instance($mod->modname, $mod->instance, $form->course)) {
$modinstances[$mod->modname][$module->id] = $module->name;
}
}
ksort($modinstances); // sort by module name
// print out a select dropdown with optgroups
echo '<select id="menuactivitylink" name="activitylink">';
if ($form->activitylink == 0) {
echo '<option selected="selected" value="0">'.get_string('none')."</option>\n";
} else {
echo '<option value="0">'.get_string('none')."</option>\n";
}
foreach ($modinstances as $module => $instances) {
echo '<optgroup label="'.get_string('modulename', $module).'">'."\n";
asort($instances);
foreach ($instances as $modid => $instance) {
if ($form->activitylink == $modid) { // check for being selected
echo '<option selected="selected" value="'.$modid.'">'.$instance."</option>\n";
} else {
echo '<option value="'.$modid.'">'.$instance."</option>\n";
if ($mods = get_course_mods($form->course)) {
$modinstances = array();
foreach ($mods as $mod) {
if ($mod->instance == $form->instance and $mod->module == $form->module) { // don't add this lesson
continue;
}
// get the module name and then store it in a new array
if ($module = get_coursemodule_from_instance($mod->modname, $mod->instance, $form->course)) {
$modinstances[$mod->modname][$module->id] = $module->name;
}
}
echo "</optgroup>\n";
ksort($modinstances); // sort by module name
// print out a select dropdown with optgroups
echo '<select id="menuactivitylink" name="activitylink">';
if ($form->activitylink == 0) {
echo '<option selected="selected" value="0">'.get_string('none')."</option>\n";
} else {
echo '<option value="0">'.get_string('none')."</option>\n";
}
foreach ($modinstances as $module => $instances) {
echo '<optgroup label="'.get_string('modulename', $module).'">'."\n";
asort($instances);
foreach ($instances as $modid => $instance) {
if ($form->activitylink == $modid) { // check for being selected
echo '<option selected="selected" value="'.$modid.'">'.$instance."</option>\n";
} else {
echo '<option value="'.$modid.'">'.$instance."</option>\n";
}
}
echo "</optgroup>\n";
}
echo "</select>\n";
} else {
print_string('nocoursemods', 'lesson');
}
echo "</select>\n";
helpbutton("activitylink", get_string("activitylink", "lesson"), "lesson");
?>