MDL-62960 calendar: Added range check callback for course events

Added core_calendar_get_valid_event_timestart_range callback for course events

calendar/classes/local/api.php

@@ -242,6 +242,7 @@ class api {
             $startdate->format('n'),
             $startdate->format('j')
         );
+        $starttimestamp = $starttime->getTimestamp();
 
         if ($hascoursemodule) {
             $moduleinstance = $DB->get_record(
@@ -250,7 +251,6 @@ class api {
                 '*',
                 MUST_EXIST
             );
-            $legacyevent->timestart = $starttime->getTimestamp();
 
             // If there is a timestart range callback implemented then we can
             // use the values returned from the valid timestart range to apply
@@ -262,20 +262,30 @@ class api {
                 [$legacyevent, $moduleinstance],
                 [false, false]
             );
+        } else if ($legacyevent->courseid != 0 && $legacyevent->courseid != SITEID && $legacyevent->groupid == 0) {
+            // This is a course event.
+            list($min, $max) = component_callback(
+                'core_course',
+                'core_calendar_get_valid_event_timestart_range',
+                [$legacyevent, $event->get_course()->get_proxied_instance()],
+                [0, 0]
+            );
+        } else {
+            $min = $max = 0;
+        }
 
-            // If the callback returns false for either value it means that
-            // there is no valid time start range.
-            if ($min === false || $max === false) {
-                throw new \moodle_exception('The start day of this event can not be modified');
-            }
+        // If the callback returns false for either value it means that
+        // there is no valid time start range.
+        if ($min === false || $max === false) {
+            throw new \moodle_exception('The start day of this event can not be modified');
+        }
 
-            if ($min && $legacyevent->timestart < $min[0]) {
-                throw new \moodle_exception($min[1]);
-            }
+        if ($min && $starttimestamp < $min[0]) {
+            throw new \moodle_exception($min[1]);
+        }
 
-            if ($max && $legacyevent->timestart > $max[0]) {
-                throw new \moodle_exception($max[1]);
-            }
+        if ($max && $starttimestamp > $max[0]) {
+            throw new \moodle_exception($max[1]);
         }
 
         // This function does our capability checks.

calendar/upgrade.txt

@@ -1,6 +1,10 @@
 This files describes API changes in /calendar/* ,
 information provided here is intended especially for developers.
 
+=== 3.4.6 ===
+* added core_calendar_get_valid_event_timestart_range callback for course events when the update_event_start_day function is used
+  in the local api.
+
 === 3.4.5 ===
 * calendar_get_default_courses() function now has optional $userid parameter.
 * calendar_set_filters() function now has optional $user parameter.