L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-30466 Backup: Fixed duplicate completion record check error

Browse Source
This commit is contained in:
Rajesh Taneja
2011-11-29 09:58:11 +08:00
parent 50ce778ad8
commit b367f4106c
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backup/moodle2/restore_stepslib.php
+5 -11
View File
@@ -2237,8 +2237,6 @@ class restore_module_structure_step extends restore_structure_step {
* - Activity includes completion info (file_exists)
*/
class restore_userscompletion_structure_step extends restore_structure_step {
private $done = array();
/**
* To conditionally decide if this step must be executed
* Note the "settings" conditions are evaluated in the
@@ -2282,15 +2280,14 @@ class restore_userscompletion_structure_step extends restore_structure_step {
$data->userid = $this->get_mappingid('user', $data->userid);
$data->timemodified = $this->apply_date_offset($data->timemodified);
// Find the existing record
$existing = $DB->get_record('course_modules_completion', array(
'coursemoduleid' => $data->coursemoduleid,
'userid' => $data->userid), 'id, timemodified');
// Check we didn't already insert one for this cmid and userid
// (there aren't supposed to be duplicates in that field, but
// it was possible until MDL-28021 was fixed).
$key = $data->coursemoduleid . ',' . $data->userid;
if (array_key_exists($key, $this->done)) {
// Find the existing record
$existing = $DB->get_record('course_modules_completion', array(
'coursemoduleid' => $data->coursemoduleid,
'userid' => $data->userid), 'id, timemodified');
if ($existing) {
// Update it to these new values, but only if the time is newer
if ($existing->timemodified < $data->timemodified) {
$data->id = $existing->id;
@@ -2299,8 +2296,6 @@ class restore_userscompletion_structure_step extends restore_structure_step {
} else {
// Normal entry where it doesn't exist already
$DB->insert_record('course_modules_completion', $data);
// Remember this entry
$this->done[$key] = true;
}
}
@@ -2308,7 +2303,6 @@ class restore_userscompletion_structure_step extends restore_structure_step {
// This gets called once per activity (according to my testing).
// Clearing the array isn't strictly required, but avoids using
// unnecessary memory.
$this->done = array();
}
}