Save two queries if we are not going to output anything.

This commit is contained in:
tjhunt
2006-08-16 16:54:20 +00:00
parent 1d723a169a
commit b169c31e39
+6 -6
View File
@@ -56,13 +56,13 @@ class quiz_report extends quiz_default_report {
}
// Print information on the number of existing attempts
if ($attemptnum = count_records('quiz_attempts', 'quiz', $quiz->id, 'preview', 0)) {
$a = new stdClass;
$a->attemptnum = $attemptnum;
$a->studentnum = count_records_select('quiz_attempts', "quiz = '$quiz->id' AND preview = '0'", 'COUNT(DISTINCT userid)');
$a->studentstring = $course->students;
if (!$download) { //do not print notices when downloading
if ($attemptnum = count_records('quiz_attempts', 'quiz', $quiz->id, 'preview', 0)) {
$a = new stdClass;
$a->attemptnum = $attemptnum;
$a->studentnum = count_records_select('quiz_attempts', "quiz = '$quiz->id' AND preview = '0'", 'COUNT(DISTINCT userid)');
$a->studentstring = $course->students;
if (!$download) { //do not print notices when downloading
notify(get_string('numattempts', 'quiz', $a));
}
}