L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-44667 database: fix incorrect usages of $DB->get_field

Browse Source 
Some places were passing 5 params, meaning the strictness param was
lost. This fixes those usages.
This commit is contained in:
Jake Dallimore
2017-12-12 09:53:02 +08:00
parent 1402bb28bc
commit b01791c076
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
enrol/imsenterprise/tests/imsenterprise_test.php
+2 -2
View File
@@ -206,7 +206,7 @@ class enrol_imsenterprise_testcase extends advanced_testcase {
$this->set_xml_file(array($imsuser));
$this->imsplugin->cron();
$this->assertEquals(1, $DB->get_field('user', 'deleted', array('id' => $user->id), '*', MUST_EXIST));
$this->assertEquals(1, $DB->get_field('user', 'deleted', array('id' => $user->id), MUST_EXIST));
}
/**
@@ -227,7 +227,7 @@ class enrol_imsenterprise_testcase extends advanced_testcase {
$this->set_xml_file(array($imsuser));
$this->imsplugin->cron();
$this->assertEquals(0, $DB->get_field('user', 'deleted', array('id' => $user->id), '*', MUST_EXIST));
$this->assertEquals(0, $DB->get_field('user', 'deleted', array('id' => $user->id), MUST_EXIST));
}
/**
mod/assign/submission/file/locallib.php
+1 -1
View File
@@ -295,7 +295,7 @@ class assign_submission_file extends assign_submission_plugin {
$groupid = 0;
// Get the group name as other fields are not transcribed in the logs and this information is important.
if (empty($submission->userid) && !empty($submission->groupid)) {
$groupname = $DB->get_field('groups', 'name', array('id' => $submission->groupid), '*', MUST_EXIST);
$groupname = $DB->get_field('groups', 'name', array('id' => $submission->groupid), MUST_EXIST);
$groupid = $submission->groupid;
} else {
$params['relateduserid'] = $submission->userid;
mod/assign/submission/onlinetext/locallib.php
+1 -1
View File
@@ -238,7 +238,7 @@ class assign_submission_onlinetext extends assign_submission_plugin {
$groupid = 0;
// Get the group name as other fields are not transcribed in the logs and this information is important.
if (empty($submission->userid) && !empty($submission->groupid)) {
$groupname = $DB->get_field('groups', 'name', array('id' => $submission->groupid), '*', MUST_EXIST);
$groupname = $DB->get_field('groups', 'name', array('id' => $submission->groupid), MUST_EXIST);
$groupid = $submission->groupid;
} else {
$params['relateduserid'] = $submission->userid;
question/type/multianswer/questiontype.php
+1 -1
View File
@@ -46,7 +46,7 @@ class qtype_multianswer extends question_type {
// Get relevant data indexed by positionkey from the multianswers table.
$sequence = $DB->get_field('question_multianswer', 'sequence',
array('question' => $question->id), '*', MUST_EXIST);
array('question' => $question->id), MUST_EXIST);
$wrappedquestions = $DB->get_records_list('question', 'id',
explode(',', $sequence), 'id ASC');