L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-74332 mod_survey: Critical incidents dont require summary and scales

Browse Source 
Do not show summary and scales for the survey with critical
incidents. So critical incidents survey would have questions
and participants only under response reports.
Also corrected the heading for the Questions page.
This commit is contained in:
Sujith Haridasan
2022-04-04 09:59:03 +05:30
parent 6e7c7a7e2e
commit aee71c329d
3 changed files with 73 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/survey/lib.php
+10 -5
View File
@@ -810,16 +810,21 @@ function survey_supports($feature) {
* @param navigation_node $surveynode
*/
function survey_extend_settings_navigation($settings, $surveynode) {
global $PAGE;
global $PAGE, $DB;
if (has_capability('mod/survey:readresponses', $PAGE->cm->context)) {
$responsesnode = $surveynode->add(get_string("responsereports", "survey"));
$url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action'=>'summary'));
$responsesnode->add(get_string("summary", "survey"), $url);
$url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action'=>'scales'));
$responsesnode->add(get_string("scales", "survey"), $url);
$cm = get_coursemodule_from_id('survey', $PAGE->cm->id);
$survey = $DB->get_record("survey", ["id" => $cm->instance]);
if ($survey && ($survey->template != SURVEY_CIQ)) {
$url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action' => 'summary'));
$responsesnode->add(get_string("summary", "survey"), $url);
$url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action' => 'scales'));
$responsesnode->add(get_string("scales", "survey"), $url);
}
$url = new moodle_url('/mod/survey/report.php', array('id' => $PAGE->cm->id, 'action'=>'questions'));
$responsesnode->add(get_string("question", "survey"), $url);
mod/survey/report.php
+10 -1
View File
@@ -97,7 +97,13 @@
$PAGE->navbar->add(get_string('downloadresults', 'survey'));
break;
case 'summary':
if ($survey->template == SURVEY_CIQ) {
throw new moodle_exception('cannotviewreport');
}
case 'scales':
if ($survey->template == SURVEY_CIQ) {
throw new moodle_exception('cannotviewreport');
}
case 'questions':
$PAGE->navbar->add($strreport);
$PAGE->navbar->add(${'str'.$action});
@@ -248,7 +254,7 @@
$questions = $DB->get_records_list("survey_questions", "id", explode(',',$survey->questions));
$questionorder = explode(",", $survey->questions);
echo $OUTPUT->heading($strallquestions, 3);
echo $OUTPUT->heading($strquestions, 3);
}
if (! $results = survey_get_responses($survey->id, $currentgroup, $groupingid) ) {
@@ -517,6 +523,9 @@
break;
default:
throw new moodle_exception('cannotviewreport');
}
echo $OUTPUT->footer();
mod/survey/tests/behat/survey_critical_incidents.feature
+53
View File
@@ -0,0 +1,53 @@
@mod @mod_survey @javascript
Feature: A teacher navigates to response reports of students
If survey activity is configured for critical students
Only questions and particiats pages should be visible under response reports
Background:
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@example.com |
| student1 | Student | 1 | student1@example.com |
| student2 | Student | 1 | student2@example.com |
And the following "courses" exist:
| fullname | shortname | category | enablecompletion |
| Course 1 | C1 | 0 | 1 |
And the following "course enrolments" exist:
| user | course | role |
| teacher1 | C1 | editingteacher |
| student1 | C1 | student |
| student2 | C1 | student |
And the following "activities" exist:
| activity | name | intro | course | idnumber | section |
| survey | Test survey name | Test survey description | C1 | survey1 | 1 |
Scenario: Only questions and participants page should be available under response reports as teacher
Given I am on the "Test survey name" "survey activity" page logged in as teacher1
And I navigate to "Edit settings" in current page administration
And I set the following fields to these values:
| Survey type | Critical incidents |
And I press "Save and return to course"
And I log out
And I am on the "Test survey name" "survey activity" page logged in as student1
And I set the field "At what moment in class were you most engaged as a learner?" to "most engaged as student1"
And I set the field "At what moment in class were you most distanced as a learner?" to "most distanced as student1"
And I set the field "What action from anyone in the forums did you find most affirming or helpful?" to "most helpful student1"
And I set the field "What action from anyone in the forums did you find most puzzling or confusing?" to "most confusing student1"
And I set the field "What event surprised you most?" to "most surprised student1"
And I press "Click here to continue"
And I press "Continue"
And I log out
And I am on the "Test survey name" "survey activity" page logged in as student2
And I set the field "At what moment in class were you most engaged as a learner?" to "most engaged as student2"
And I set the field "At what moment in class were you most distanced as a learner?" to "most distanced as student2"
And I set the field "What action from anyone in the forums did you find most affirming or helpful?" to "most helpful student2"
And I set the field "What action from anyone in the forums did you find most puzzling or confusing?" to "most confusing student2"
And I set the field "What event surprised you most?" to "most surprised student1"
And I press "Click here to continue"
And I press "Continue"
And I log out
When I am on the "Test survey name" "survey activity" page logged in as teacher1
And "Summary" "link" should not exist in current page administration
And "Scales" "link" should not exist in current page administration
And "Response reports > Question" "link" should exist in current page administration
And "Response reports > Participants" "link" should exist in current page administration