L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-82335_405' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_405_STABLE

Browse Source
This commit is contained in:
Huong Nguyen
2024-11-07 09:31:45 +07:00
parent 38f99a1e60 1ecc215b3a
commit aeace8ee75
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/bank/columnsortorder/db/upgrade.php
+15 -1
View File
@@ -42,7 +42,7 @@ function xmldb_qbank_columnsortorder_upgrade(int $oldversion): bool {
$pluginconfigs = $DB->get_records('config_plugins', ['plugin' => 'qbank_columnsortorder'], 'name');
foreach ($pluginconfigs as $config) {
if ($config->name == 'version') {
if (!in_array($config->name, ['hiddencols', 'enabledcol', 'disabledcol'])) {
continue;
}
$fields = explode(',', $config->value);
@@ -77,6 +77,20 @@ function xmldb_qbank_columnsortorder_upgrade(int $oldversion): bool {
upgrade_plugin_savepoint(true, 2024051000, 'qbank', 'columnsortorder');
}
if ($oldversion < 2024100701) {
// When upgrading to version 2024042201, if there were any values for colsize in qbank_columnsortorder plugin,
// they were getting incorrectly updated, resulting in corrupted colsize value,
// e.g., '"width":"30"}-"width":"30"},"width":"180"}-"width":"180"} and thus breaking the question bank page.
$pluginconfig = $DB->get_record('config_plugins', ['plugin' => 'qbank_columnsortorder', 'name' => 'colsize']);
if ($pluginconfig) {
$pattern = '/"width":"[^"]*"}-"width":"[^"]*"}/';
if (preg_match($pattern, $pluginconfig->value)) {
$DB->delete_records('config_plugins', ['plugin' => 'qbank_columnsortorder', 'name' => 'colsize']);
}
}
upgrade_plugin_savepoint(true, 2024100701, 'qbank', 'columnsortorder');
}
// Automatically generated Moodle v4.5.0 release upgrade line.
// Put any upgrade step following this.
question/bank/columnsortorder/version.php
+1 -1
View File
@@ -26,6 +26,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->component = 'qbank_columnsortorder';
$plugin->version = 2024100700;
$plugin->version = 2024100701;
$plugin->requires = 2024100100;
$plugin->maturity = MATURITY_STABLE;