L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-27401 Unit test errors in lib/simpletest/testpagelib_moodlepage.php

Browse Source
This commit is contained in:
sam marshall
2011-05-09 11:17:03 +01:00
parent 8351ce1bd0
commit adabef8bf6
2 changed files with 20 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/simpletest/testpagelib_moodlepage.php
+18 -23
View File
@@ -525,7 +525,7 @@ class moodle_page_cm_test extends UnitTestCaseUsingDatabase {
parent::setUp();
$this->originalcourse = $COURSE;
$this->testpage = new moodle_page();
$this->create_test_tables(array('course', 'context'), 'lib');
$this->create_test_tables(array('course', 'context', 'modules', 'course_modules', 'course_modules_availability', 'grade_items', 'course_sections'), 'lib');
$this->create_test_table('forum', 'mod/forum');
$this->switch_to_test_db();
@@ -551,6 +551,7 @@ class moodle_page_cm_test extends UnitTestCaseUsingDatabase {
$course->fullname = 'Anonymous test course';
$course->shortname = 'ANON';
$course->summary = '';
$course->modinfo = null;
$course->id = $this->testdb->insert_record('course', $course);
$forum = new stdClass;
@@ -559,12 +560,23 @@ class moodle_page_cm_test extends UnitTestCaseUsingDatabase {
$forum->intro = '';
$forum->id = $this->testdb->insert_record('forum', $forum);
$module = new stdClass;
$module->name = 'forum';
$module->id = $this->testdb->insert_record('modules', $module);
$cm = new stdClass;
$cm->id = 13;
$cm->course = $course->id;
$cm->instance = $forum->id;
$cm->modname = 'forum';
$cm->module = $module->id;
$cm->name = $forum->name;
$cm->id = $this->testdb->insert_record('course_modules', $cm);
$section = new stdClass;
$section->course = $course->id;
$section->section = 0;
$section->sequence = $cm->id;
$section->id = $this->testdb->insert_record('course_sections', $section);
$context = new stdClass;
$context->contextlevel = CONTEXT_MODULE;
@@ -590,26 +602,6 @@ class moodle_page_cm_test extends UnitTestCaseUsingDatabase {
$this->assert(new CheckSpecifiedFieldsExpectation($cm), $this->testpage->cm);
}
public function test_cannot_set_cm_without_name() {
// Setup fixture
list($cm) = $this->create_a_forum_with_context();
// Set expectation
$this->expectException();
// Exercise SUT
unset($cm->name);
$this->testpage->set_cm($cm);
}
public function test_cannot_set_cm_without_modname() {
// Setup fixture
list($cm) = $this->create_a_forum_with_context();
// Set expectation
$this->expectException();
// Exercise SUT
unset($cm->modname);
$this->testpage->set_cm($cm);
}
public function test_cannot_set_activity_record_before_cm() {
// Setup fixture
list($cm, $course, $forum) = $this->create_a_forum_with_context();
@@ -672,18 +664,21 @@ class moodle_page_cm_test extends UnitTestCaseUsingDatabase {
$this->testpage->set_activity_record($forum);
}
public function test_settin_cm_sets_course() {
public function test_setting_cm_sets_course() {
// Setup fixture
list($cm, $course) = $this->create_a_forum_with_context();
// Exercise SUT
$this->testpage->set_cm($cm);
// Validate
unset($course->modinfo); // This changed, but we don't care
$this->assert(new CheckSpecifiedFieldsExpectation($course), $this->testpage->course);
}
public function test_set_cm_with_course_and_activity_no_db() {
// Setup fixture
list($cm, $course, $forum) = $this->create_a_forum_with_context();
// This only works without db if we already have modinfo cache
$modinfo = get_fast_modinfo($course);
$this->drop_test_table('forum');
$this->drop_test_table('course');
// Exercise SUT
lib/simpletestlib.php
+2
View File
@@ -715,6 +715,8 @@ class UnitTestCaseUsingDatabase extends UnitTestCase {
if ($cleanmore) {
accesslib_clear_all_caches_for_unit_testing();
$course = 'reset';
get_fast_modinfo($course);
}
}