L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-19210 eliminate the generation of multiple dataitems having the same item number

Browse Source
This commit is contained in:
pichetp
2009-05-21 12:10:42 +00:00
parent e5e2fc0599
commit ad3a4aa67f
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/calculated/questiontype.php
+13 -2
View File
@@ -976,8 +976,19 @@ class question_calculated_qtype extends default_questiontype {
WHERE definition = ? ORDER BY itemnumber", array($datasetdef->id));
}
for ($numberadded =$maxnumber+1 ; $numberadded <= $maxnumber+$numbertoadd ; $numberadded++){
if (isset($datasetdefs[$defid]->items[$numberadded]) && ! $regenerate ){
// echo "<p>Reuse an previously used record".$numberadded."id".$datasetdef->id."</p>";
if (isset($datasetdefs[$defid]->items[$numberadded]) ){
// in case of regenerate it modifies the already existing record
if ( $regenerate ) {
$datasetitem = new stdClass;
$datasetitem->id = $datasetdefs[$defid]->items[$numberadded]->id;
$datasetitem->definition = $datasetdef->id ;
$datasetitem->itemnumber = $numberadded;
$datasetitem->value = $this->generate_dataset_item($datasetdef->options);
if (!$DB->update_record('question_dataset_items', $datasetitem)) {
print_error('cannotupdateitem', 'question');
}
}
//if not regenerate do nothing as there is already a record
} else {
$datasetitem = new stdClass;
$datasetitem->definition = $datasetdef->id ;