L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-17998 forum ajax rating - avoid 'null' printout + improved search by class (IE7, you know)

Browse Source
This commit is contained in:
stronk7
2009-01-23 16:30:13 +00:00
parent ee71dd5d5b
commit aacdd2a2aa
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/forum/rate_ajax.js
+4 -4
View File
@@ -144,17 +144,17 @@ function display_response(menu, response) {
/** Process ok response, displaying it **/
var ratingsDiv = YAHOO.util.Dom.getAncestorByTagName(menu, 'div');
var ratingsSpan = YAHOO.util.Dom.getFirstChildBy(ratingsDiv, function(el){return el.getAttribute('class') == 'forumpostratingtext';});
var ratingsSpan = YAHOO.util.Dom.getFirstChildBy(ratingsDiv, function(el){return YAHOO.util.Dom.hasClass(el,'forumpostratingtext');});
/** span doesn't exist (first rate), add it, shouldn't happen ever but... **/
/** span doesn't exist (first rate), add it, shouldn't happen ever but... fallback**/
if (!ratingsSpan) {
var ratingsSpan = document.createElement('span');
ratingsSpan = document.createElement('span');
YAHOO.util.Dom.addClass(ratingsSpan, 'forumpostratingtext');
ratingsDiv.appendChild(ratingsSpan);
}
/** finally replace span HTML **/
ratingsSpan.innerHTML = response.message;
ratingsSpan.innerHTML = response.message ? response.message : ''; /** Prevent null to be printed in IE7 **/
}
/**