MDL-69672 core_contentbank: Check used context level
This commit is contained in:
@@ -36,6 +36,10 @@ use context;
|
||||
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
||||
*/
|
||||
class contentbank {
|
||||
|
||||
/** @var array All the context levels allowed in the content bank */
|
||||
private const ALLOWED_CONTEXT_LEVELS = [CONTEXT_SYSTEM, CONTEXT_COURSECAT, CONTEXT_COURSE];
|
||||
|
||||
/** @var array Enabled content types. */
|
||||
private $enabledcontenttypes = null;
|
||||
|
||||
@@ -334,4 +338,14 @@ class contentbank {
|
||||
|
||||
return $contenttypes;
|
||||
}
|
||||
|
||||
/**
|
||||
* Whether the context is allowed.
|
||||
*
|
||||
* @param context $context Context to check.
|
||||
* @return bool
|
||||
*/
|
||||
public function is_context_allowed(context $context): bool {
|
||||
return in_array($context->contextlevel, self::ALLOWED_CONTEXT_LEVELS);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -30,6 +30,12 @@ $contextid = required_param('contextid', PARAM_INT);
|
||||
$pluginname = required_param('plugin', PARAM_PLUGIN);
|
||||
$id = optional_param('id', null, PARAM_INT);
|
||||
$context = context::instance_by_id($contextid, MUST_EXIST);
|
||||
|
||||
$cb = new \core_contentbank\contentbank();
|
||||
if (!$cb->is_context_allowed($context)) {
|
||||
print_error('contextnotallowed', 'core_contentbank');
|
||||
}
|
||||
|
||||
require_capability('moodle/contentbank:access', $context);
|
||||
|
||||
$returnurl = new \moodle_url('/contentbank/view.php', ['id' => $id]);
|
||||
|
||||
@@ -30,6 +30,11 @@ $contextid = optional_param('contextid', \context_system::instance()->id, PAR
|
||||
$search = optional_param('search', '', PARAM_CLEAN);
|
||||
$context = context::instance_by_id($contextid, MUST_EXIST);
|
||||
|
||||
$cb = new \core_contentbank\contentbank();
|
||||
if (!$cb->is_context_allowed($context)) {
|
||||
print_error('contextnotallowed', 'core_contentbank');
|
||||
}
|
||||
|
||||
require_capability('moodle/contentbank:access', $context);
|
||||
|
||||
$statusmsg = optional_param('statusmsg', '', PARAM_ALPHANUMEXT);
|
||||
@@ -47,7 +52,6 @@ $PAGE->set_heading($title);
|
||||
$PAGE->set_pagetype('contentbank');
|
||||
|
||||
// Get all contents managed by active plugins where the user has permission to render them.
|
||||
$cb = new \core_contentbank\contentbank();
|
||||
$contenttypes = [];
|
||||
$enabledcontenttypes = $cb->get_enabled_content_types();
|
||||
foreach ($enabledcontenttypes as $contenttypename) {
|
||||
|
||||
@@ -32,6 +32,11 @@ require_login();
|
||||
$contextid = optional_param('contextid', \context_system::instance()->id, PARAM_INT);
|
||||
$context = context::instance_by_id($contextid, MUST_EXIST);
|
||||
|
||||
$cb = new \core_contentbank\contentbank();
|
||||
if (!$cb->is_context_allowed($context)) {
|
||||
print_error('contextnotallowed', 'core_contentbank');
|
||||
}
|
||||
|
||||
require_capability('moodle/contentbank:upload', $context);
|
||||
|
||||
$title = get_string('contentbank');
|
||||
@@ -55,7 +60,6 @@ if (has_capability('moodle/user:ignoreuserquota', $context)) {
|
||||
$maxareabytes = FILE_AREA_MAX_BYTES_UNLIMITED;
|
||||
}
|
||||
|
||||
$cb = new \core_contentbank\contentbank();
|
||||
$accepted = $cb->get_supported_extensions_as_string($context);
|
||||
|
||||
$data = new stdClass();
|
||||
|
||||
@@ -33,6 +33,7 @@ $string['contentrenamed'] = 'The content has been renamed.';
|
||||
$string['contentsmoved'] = 'Content bank contents moved to {$a}.';
|
||||
$string['contenttypenoaccess'] = 'You cannot view this {$a} instance.';
|
||||
$string['contenttypenoedit'] = 'You can not edit this content';
|
||||
$string['contextnotallowed'] = 'Context is not allowed';
|
||||
$string['emptynamenotallowed'] = 'Empty name is not allowed';
|
||||
$string['eventcontentcreated'] = 'Content created';
|
||||
$string['eventcontentdeleted'] = 'Content deleted';
|
||||
|
||||
Reference in New Issue
Block a user