L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-72246 core_completion: Stop testing the inner workings of get_data()

Browse Source
This commit is contained in:
Andrew Nicols
2022-02-08 11:22:14 +08:00
parent 6652ec135b
commit a999b12e02
1 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/completionlib_test.php
-20
View File
@@ -760,26 +760,6 @@ class core_completionlib_testcase extends advanced_testcase {
$this->assertEquals(0, $result->id);
}
// Check caching.
$key = "{$user->id}_{$this->course->id}";
$cache = cache::make('core', 'completion');
if ($iscached) {
// If we expect this to be cached, then fetching the result must match the cached data.
$this->assertEquals($result, (object)$cache->get($key)[$cm->id]);
// Check cached data for other course modules in the course.
// The sample module created in setup_data() should suffice to confirm this.
$othercm = get_coursemodule_from_instance('forum', $this->module1->id);
if ($wholecourse) {
$this->assertArrayHasKey($othercm->id, $cache->get($key));
} else {
$this->assertArrayNotHasKey($othercm->id, $cache->get($key));
}
} else {
// Otherwise, this should not be cached.
$this->assertFalse($cache->get($key));
}
// Check that we are including relevant completion data for the module.
if (!$wholecourse) {
$this->assertTrue(property_exists($result, 'viewed'));