MDL-26404 messages - move textlib instance out from loop

This commit is contained in:
Eloy Lafuente (stronk7)
2011-02-28 10:35:21 +01:00
parent 77e4bb774b
commit a8ccca5325
+1 -1
View File
@@ -448,6 +448,7 @@ function message_print_contacts($onlinecontacts, $offlinecontacts, $strangers, $
*/
function message_print_usergroup_selector($viewing, $courses, $coursecontexts, $countunreadtotal, $countblocked, $strunreadmessages) {
$options = array();
$textlib = textlib_get_instance(); // going to use textlib services
if ($countunreadtotal>0) { //if there are unread messages
$options[VIEW_UNREAD_MESSAGES] = $strunreadmessages;
@@ -465,7 +466,6 @@ function message_print_usergroup_selector($viewing, $courses, $coursecontexts, $
foreach($courses as $course) {
if (has_capability('moodle/course:viewparticipants', $coursecontexts[$course->id])) {
//Not using short_text() as we want the end of the course name. Not the beginning.
$textlib = textlib_get_instance();
if ($textlib->strlen($course->shortname) > MESSAGE_MAX_COURSE_NAME_LENGTH) {
$courses_options[VIEW_COURSE.$course->id] = '...'.$textlib->substr($course->shortname, -MESSAGE_MAX_COURSE_NAME_LENGTH);
} else {