L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-60967 calendar: preload contexts in course_filter_selector

Browse Source
This commit is contained in:
Ryan Wyllie
2018-01-09 03:04:41 +00:00
parent 013f0b2266
commit a606f2e2c5
1 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
calendar/renderer.php
+23 -1
View File
@@ -243,19 +243,41 @@ class core_calendar_renderer extends plugin_renderer_base {
* @return string
*/
public function course_filter_selector(moodle_url $returnurl, $label = null, $courseid = null) {
global $CFG;
global $CFG, $DB;
if (!isloggedin() or isguestuser()) {
return '';
}
$contextrecords = [];
$courses = calendar_get_default_courses($courseid, 'id, shortname');
if (!empty($courses) && count($courses) > CONTEXT_CACHE_MAX_SIZE) {
// We need to pull the context records from the DB to preload them
// below. The calendar_get_default_courses code will actually preload
// the contexts itself however the context cache is capped to a certain
// amount before it starts recycling. Unfortunately that starts to happen
// quite a bit if a user has access to a large number of courses (e.g. admin).
// So in order to avoid hitting the DB for each context as we loop below we
// can load all of the context records and add them to the cache just in time.
$courseids = array_map(function($c) {
return $c->id;
}, $courses);
list($insql, $params) = $DB->get_in_or_equal($courseids);
$contextsql = "SELECT ctx.instanceid, " . context_helper::get_preload_record_columns_sql('ctx') .
" FROM {context} ctx WHERE ctx.contextlevel = ? AND ctx.instanceid $insql";
array_unshift($params, CONTEXT_COURSE);
$contextrecords = $DB->get_records_sql($contextsql, $params);
}
unset($courses[SITEID]);
$courseoptions = array();
$courseoptions[SITEID] = get_string('fulllistofcourses');
foreach ($courses as $course) {
if (isset($contextrecords[$course->id])) {
context_helper::preload_from_record($contextrecords[$course->id]);
}
$coursecontext = context_course::instance($course->id);
$courseoptions[$course->id] = format_string($course->shortname, true, array('context' => $coursecontext));
}