L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CHAR fields NOT NULL must not have any empty default specified!

Browse Source 
Oracle breaks with empty defaults because they are = NULL.

Leaving them as NULL, XMLDB will apply defaults for each DB properly.
This commit is contained in:
stronk7
2007-01-28 00:12:32 +00:00
parent ad88038fdb
commit a54d16ef2e
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/db/upgrade.php
+4 -4
View File
@@ -166,11 +166,11 @@ function xmldb_main_upgrade($oldversion=0) {
$f = $table->addFieldInfo('deleted', XMLDB_TYPE_INTEGER, '1', XMLDB_UNSIGNED,
XMLDB_NOTNULL, null, null, null, 0);
$f = $table->addFieldInfo('wwwroot', XMLDB_TYPE_CHAR, '255', null,
XMLDB_NOTNULL, null, null, null, '');
XMLDB_NOTNULL, null, null, null, null);
$f = $table->addFieldInfo('ip_address', XMLDB_TYPE_CHAR, '39', null,
XMLDB_NOTNULL, null, null, null, '');
XMLDB_NOTNULL, null, null, null, null);
$f = $table->addFieldInfo('name', XMLDB_TYPE_CHAR, '80', null,
XMLDB_NOTNULL, null, null, null, '');
XMLDB_NOTNULL, null, null, null, null);
$f = $table->addFieldInfo('public_key', XMLDB_TYPE_TEXT, 'medium', null,
XMLDB_NOTNULL, null, null, null, null);
$f = $table->addFieldInfo('public_key_expires', XMLDB_TYPE_INTEGER, '10', XMLDB_UNSIGNED,
@@ -409,7 +409,7 @@ function xmldb_main_upgrade($oldversion=0) {
$f = $table->addFieldInfo('sortorder', XMLDB_TYPE_INTEGER, '4', XMLDB_UNSIGNED,
XMLDB_NOTNULL, NULL, null, null, 0);
$f = $table->addFieldInfo('fullname', XMLDB_TYPE_CHAR, '254', null,
XMLDB_NOTNULL, NULL, null, null, '');
XMLDB_NOTNULL, NULL, null, null, null);
$f = $table->addFieldInfo('shortname', XMLDB_TYPE_CHAR, '15', null,
XMLDB_NOTNULL, NULL, null, null, null);
$f = $table->addFieldInfo('idnumber', XMLDB_TYPE_CHAR, '100', null,