L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29336 Saving grade mapping table in the Workshop

Browse Source 
The Workshop module using the "Number of errors" grading strategy did
not save all items in the grade mapping table. If some assessment form
fields have weight > 1, the number of possible errors is greater that
the number of the assessment form fields. The previous code deleted all
mappings where the number of errors was greater than the number of
fields.

In this patch, the maximum number of possible errors is calculated as a
sum of weights of all fields. Only mappings over this maximum are
deleted now.
This commit is contained in:
David Mudrak
2011-09-22 05:17:44 +02:00
parent 136fa79e34
commit a39eb49fc2
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/form/numerrors/lib.php
+4 -2
View File
@@ -164,6 +164,7 @@ class workshop_numerrors_strategy implements workshop_strategy {
$records = $data->numerrors; // data to be saved into {workshopform_numerrors}
$mappings = $data->mappings; // data to be saved into {workshopform_numerrors_map}
$todelete = array(); // dimension ids to be deleted
$maxnonegative = 0; // maximum number of (weighted) negative responses
for ($i=0; $i < $norepeats; $i++) {
$record = $records[$i];
@@ -181,6 +182,7 @@ class workshop_numerrors_strategy implements workshop_strategy {
// exiting field
$DB->update_record('workshopform_numerrors', $record);
}
$maxnonegative += $record->weight;
// re-save with correct path to embeded media files
$record = file_postupdate_standard_editor($record, 'description', $this->descriptionopts, $PAGE->context,
'workshopform_numerrors', 'description', $record->id);
@@ -212,8 +214,8 @@ class workshop_numerrors_strategy implements workshop_strategy {
$insql = '';
}
$sql = "DELETE FROM {workshopform_numerrors_map}
WHERE (($insql nonegative > :nodimensions) AND (workshopid = :workshopid))";
$params['nodimensions'] = $norepeats;
WHERE (($insql nonegative > :maxnonegative) AND (workshopid = :workshopid))";
$params['maxnonegative'] = $maxnonegative;
$params['workshopid'] = $this->workshop->id;
$DB->execute($sql, $params);
}