L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix for bug 4242/4243. Optimize insert_record.

Browse Source
This commit is contained in:
moodler
2005-10-31 06:25:17 +00:00
parent fd5d7fad8b
commit a2bed05944
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/datalib.php
+14 -7
View File
@@ -1131,18 +1131,25 @@ function delete_records_select($table, $select='') {
function insert_record($table, $dataobject, $returnid=true, $primarykey='id') {
global $db, $CFG;
static $empty_rs_cache;
if (defined('MDL_PERFDB')) { global $PERF ; $PERF->dbqueries++; };
/// Execute a dummy query to get an empty recordset
if (!$rs = $db->Execute('SELECT * FROM '. $CFG->prefix . $table .' WHERE '. $primarykey .' = \'-1\'')) {
return false;
/// Get an empty recordset. Cache for multiple inserts.
if (empty($empty_rs_cache[$table])) {
/// Execute a dummy query to get an empty recordset
if (!$empty_rs_cache[$table] = $db->Execute('SELECT * FROM '. $CFG->prefix . $table .' WHERE '. $primarykey .' = \'-1\'')) {
return false;
}
/// In Moodle we always use auto-numbering fields for the primary ID
/// so let's unset it now before it causes any trouble
unset($dataobject->{$primarykey});
}
/// In Moodle we always use auto-numbering fields for the primary ID
/// so let's unset it now before it causes any trouble
unset($dataobject->id);
$rs = $empty_rs_cache[$table];
/// Postgres doesn't have the concept of primary key built in
/// and will return the OID which isn't what we want.