L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-79442-master' of https://github.com/snake/moodle

Browse Source
This commit is contained in:
Jun Pataleta
2023-09-26 11:48:31 +08:00
parent 3c2589fb58 26d0ac156e
commit a24e9872ef
1 changed files with 3 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lti/locallib.php
+3 -9
View File
@@ -1508,16 +1508,10 @@ function content_item_to_form(object $tool, object $typeconfig, object $item) :
}
$config->instructorchoicesendname = LTI_SETTING_NEVER;
$config->instructorchoicesendemailaddr = LTI_SETTING_NEVER;
// Since 4.3, the launch container is dictated by the value set in tool configuration and isn't controllable by content items.
$config->launchcontainer = LTI_LAUNCH_CONTAINER_DEFAULT;
if (isset($item->placementAdvice->presentationDocumentTarget)) {
if ($item->placementAdvice->presentationDocumentTarget === 'window') {
$config->launchcontainer = LTI_LAUNCH_CONTAINER_WINDOW;
} else if ($item->placementAdvice->presentationDocumentTarget === 'frame') {
$config->launchcontainer = LTI_LAUNCH_CONTAINER_EMBED_NO_BLOCKS;
} else if ($item->placementAdvice->presentationDocumentTarget === 'iframe') {
$config->launchcontainer = LTI_LAUNCH_CONTAINER_EMBED;
}
}
if (isset($item->custom)) {
$config->instructorcustomparameters = params_to_string($item->custom);
}