L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-58613 workshop: Provide all data to display user name

Browse Source 
Additional fields such as middlename, alternatename and others were not
passed to the fullname(), causing a debugging message.
This commit is contained in:
David Mudrák
2017-04-19 14:19:56 +02:00
parent 6fd68f6967
commit a22951044f
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/allocation/random/lib.php
+8 -7
View File
@@ -164,13 +164,14 @@ class workshop_random_allocator implements workshop_allocator {
// by reviewer
$result->log(get_string('numofdeallocatedassessment', 'workshopallocation_random', count($delassessments)), 'info');
foreach ($delassessments as $delassessmentkey => $delassessmentid) {
$a = new stdclass();
$a->authorname = fullname((object)array(
'lastname' => $assessments[$delassessmentid]->authorlastname,
'firstname' => $assessments[$delassessmentid]->authorfirstname));
$a->reviewername = fullname((object)array(
'lastname' => $assessments[$delassessmentid]->reviewerlastname,
'firstname' => $assessments[$delassessmentid]->reviewerfirstname));
$author = (object) [];
$reviewer = (object) [];
username_load_fields_from_object($author, $assessments[$delassessmentid], 'author');
username_load_fields_from_object($reviewer, $assessments[$delassessmentid], 'reviewer');
$a = [
'authorname' => fullname($author),
'reviewername' => fullname($reviewer),
];
if (!is_null($assessments[$delassessmentid]->grade)) {
$result->log(get_string('allocationdeallocategraded', 'workshopallocation_random', $a), 'error', 1);
unset($delassessments[$delassessmentkey]);