L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-74718 webdav: correct the loop when reading chunks

Browse Source 
Adjusted the condition while reading the streams
in chunks. Read till the end to make sure we have got all
the data. Else we might not get all the data to show
in file picker.
This commit is contained in:
Sujith Haridasan
2022-06-09 12:03:38 +05:30
parent ac39bac81b
commit a22898e2af
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/webdavlib.php
+2 -6
View File
@@ -1561,7 +1561,7 @@ EOD;
$chunk_size = ($mod == $max_chunk_size ? $max_chunk_size : $matches[1] - strlen($chunk));
$chunk .= fread($this->sock, $chunk_size);
$this->_error_log('mod: ' . $mod . ' chunk: ' . $chunk_size . ' total: ' . strlen($chunk));
} while ($mod == $max_chunk_size);
} while (strlen($chunk) < $matches[1]);
}
self::update_file_or_buffer($chunk, $fp, $buffer);
break;
@@ -1586,11 +1586,7 @@ EOD;
self::update_file_or_buffer($chunk, $fp, $buffer);
$loadsize += strlen($chunk);
$this->_error_log('mod: ' . $mod . ' chunk: ' . $chunk_size . ' total: ' . $loadsize);
} while ($mod == $max_chunk_size);
if ($loadsize < $matches[1]) {
$chunk = fread($this->sock, $matches[1] - $loadsize);
self::update_file_or_buffer($chunk, $fp, $buffer);
}
} while ($matches[1] > $loadsize);
break;
// check for 204 No Content