MDL-27521 Updates the can_finalize and can_unfinalize methods to deal with passing a submission object that isn't one (in this case is a Boolean value). This will result in both methods now returning false. Kick on effect is that it corrects the bug described in MDL-27521 by removing the button if it isn't possible to finalize the submission.

2011-11-01 11:45:10 +08:00
parent e1fe0c5189
commit 9fee0258a4
1 changed files with 10 additions and 0 deletions
@@ -919,9 +919,14 @@ class assignment_upload extends assignment_base {
    }

    function can_unfinalize($submission) {
+        if(is_bool($submission)) {
+            return false;
+        }
+
        if (!$this->drafts_tracked()) {
            return false;
        }
+
        if (has_capability('mod/assignment:grade', $this->context)
          and $this->isopen()
          and $this->is_finalized($submission)) {
@@ -933,6 +938,11 @@ class assignment_upload extends assignment_base {

    function can_finalize($submission) {
        global $USER;
+
+        if(is_bool($submission)) {
+            return false;
+        }
+
        if (!$this->drafts_tracked()) {
            return false;
        }