L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-54010 roles: Fix missing HTMLspecialchars in role export code.

Browse Source 
Role name and description fields are currently not escaped when
exporting a role. This results in an unusable file when characters
such as ampersands are used in a name or description. Fix this by
using htmlspecialchars on both fields.

Signed-off-by: Nigel Cunningham <[email protected]>
This commit is contained in:
Nigel Cunningham
2016-05-26 10:32:00 +08:00
committed by Cameron Ball
parent b1b097e2b6
commit 9efa43c6a9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/roles/classes/preset.php
+2 -2
View File
@@ -71,8 +71,8 @@ class core_role_preset {
$dom->appendChild($top);
$top->appendChild($dom->createElement('shortname', $role->shortname));
$top->appendChild($dom->createElement('name', $role->name));
$top->appendChild($dom->createElement('description', $role->description));
$top->appendChild($dom->createElement('name', htmlspecialchars($role->name)));
$top->appendChild($dom->createElement('description', htmlspecialchars($role->description)));
$top->appendChild($dom->createElement('archetype', $role->archetype));
$contextlevels = $dom->createElement('contextlevels');