Merge branch 'MDL-85795-405-2' of https://github.com/junpataleta/moodle into MOODLE_405_STABLE

lang/en/search.php

@@ -98,6 +98,7 @@ $string['optimize'] = 'Optimize';
 $string['order'] = 'Results order';
 $string['order_location'] = 'Prioritise results related to {$a}';
 $string['order_relevance'] = 'Most relevant results first';
+$string['performsearch'] = 'Perform search';
 $string['priority'] = 'Priority';
 $string['priority_reindexing'] = 'Reindexing';
 $string['priority_normal'] = 'Normal';
@@ -126,6 +127,7 @@ $string['searchnotpermitted'] = 'You are not allowed to do a search';
 $string['searchsetupdescription'] = 'The following steps help you to set up Moodle global search.';
 $string['searchwithin'] = 'Search within';
 $string['seconds'] = 'seconds';
+$string['sitewidesearch'] = 'Sitewide search';
 $string['solutions'] = 'Solutions';
 $string['statistics'] = 'Statistics';
 $string['step'] = 'Step';

lib/classes/output/core_renderer.php

@@ -3081,7 +3081,8 @@ EOD;
             'hiddenfields' => (object) ['name' => 'context', 'value' => $this->page->context->id],
             'inputname' => 'q',
             'searchstring' => get_string('search'),
-            ];
+            'grouplabel' => get_string('sitewidesearch', 'search'),
+        ];
         return $this->render_from_template('core/search_input_navbar', $data);
     }
 

lib/templates/search_input_navbar.mustache

@@ -38,7 +38,10 @@
             {{#hiddenfields}}
                 <input type="hidden" name="{{ name }}" value="{{ value }}">
             {{/hiddenfields}}
-            <div class="input-group">
+            <div class="input-group" {{#grouplabel}}role="group" aria-labelledby="searchgrouplabel-{{uniqid}}"{{/grouplabel}}>
+                {{#grouplabel}}
+                    <span id="searchgrouplabel-{{uniqid}}" class="sr-only">{{{ . }}}</span>
+                {{/grouplabel}}
                 <label for="searchinput-{{uniqid}}">
                     <span class="sr-only">{{{ searchstring }}}</span>
                 </label>
@@ -56,14 +59,15 @@
                         data-toggle="collapse"
                         href="#searchform-navbar"
                         role="button"
+                        title="{{#str}} closebuttontitle {{/str}}"
                     >
                         {{#pix}} e/cancel, core {{/pix}}
                         <span class="sr-only">{{#str}} closebuttontitle {{/str}}</span>
                     </a>
                 <div class="input-group-append">
-                    <button type="submit" class="btn btn-submit" data-action="submit">
+                    <button type="submit" class="btn btn-submit" data-action="submit" title="{{#str}}performsearch, search{{/str}}">
                         {{#pix}} a/search, core {{/pix}}
-                        <span class="sr-only">{{{ searchstring }}}</span>
+                        <span class="sr-only">{{#str}}performsearch, search{{/str}}</span>
                     </button>
                 </div>
             </div>

message/templates/message_drawer_view_overview_header.mustache

@@ -35,7 +35,8 @@
 }}
 <div class="border-bottom p-1 px-sm-2" aria-hidden="false" {{^isdrawer}}data-in-panel="true"{{/isdrawer}} data-region="view-overview">
     <div class="d-flex align-items-center">
-        <div class="input-group simplesearchform">
+        <div class="input-group simplesearchform" role="group" aria-labelledby="messageoverviewgrouplabel">
+            <span class="sr-only" id="messageoverviewgrouplabel">{{#str}}searchcombined, message{{/str}}</span>
             <input
                 type="text"
                 class="form-control"

message/templates/message_drawer_view_search_header.mustache

@@ -45,7 +45,8 @@
         >
             {{> core_message/message_drawer_icon_back }}
         </a>
-        <div class="input-group simplesearchform">
+        <div class="input-group simplesearchform" role="group" aria-labelledby="messagesearchgrouplabel">
+            <span class="sr-only" id="messagesearchgrouplabel">{{#str}}searchcombined, message{{/str}}</span>
             <input
                 type="text"
                 class="form-control"
@@ -58,7 +59,8 @@
                     class="btn btn-submit icon-no-margin"
                     type="button"
                     data-action="search"
-                    aria-label="{{#str}} search, core_search {{/str}}"
+                    aria-label="{{#str}} performsearch, core_search {{/str}}"
+                    title="{{#str}} performsearch, core_search {{/str}}"
                 >
                     <span data-region="search-icon-container">
                         {{#pix}} a/search, core {{/pix}}
@@ -70,4 +72,4 @@
             </div>
         </div>
     </div>
-</div>
+</div>

search/tests/behat/behat_search.php

@@ -53,7 +53,8 @@ class behat_search extends behat_base {
 
         // Submit the form.
         $this->execute("behat_general::i_click_on_in_the",
-            [get_string('search', 'core'), 'button', '#usernavigation', 'css_element']);
+            [get_string('performsearch', 'search'), 'button', '#usernavigation', 'css_element']
+        );
     }
 
     /**