L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-64551 core_question: Fix double ampersand escaping in tag button

Browse Source
This commit is contained in:
Shamim Rezaie
2019-01-14 18:21:41 +11:00
parent 4c5b60a0f9
commit 98e019455e
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/classes/bank/tags_action_column.php
+3 -5
View File
@@ -50,14 +50,12 @@ class tags_action_column extends action_column_base {
* @param string $rowclasses
*/
protected function display_content($question, $rowclasses) {
global $DB;
if (\core_tag_tag::is_enabled('core_question', 'question') &&
question_has_capability_on($question, 'view')) {
$cantag = question_has_capability_on($question, 'tag');
$qbank = $this->qbank;
$url = $qbank->edit_question_url($question->id);
$url = new \moodle_url($qbank->edit_question_url($question->id));
$editingcontext = $qbank->get_most_specific_context();
$this->print_tag_icon($question->id, $url, $cantag, $editingcontext->id);
@@ -68,11 +66,11 @@ class tags_action_column extends action_column_base {
* Build and print the tags icon.
*
* @param int $id The question ID.
* @param string $url Editing question url.
* @param \moodle_url $url Editing question url.
* @param bool $cantag Whether the user can tag questions or not.
* @param int $contextid Question category context ID.
*/
protected function print_tag_icon($id, $url, $cantag, $contextid) {
protected function print_tag_icon($id, \moodle_url $url, $cantag, $contextid) {
global $OUTPUT;
$params = [